Litestream error on restore

[danielmichaels]

Hey mate,

I updated my picoshare instance this morning and it failed to start.

The error I am getting is:

ERROR failed to run error="flag provided but not defined: -v"

I am using the docker image. Reverting from 1.4.3 (latest) to 1.4.2 fixed the issue.

Repro:

Working version:

• docker run --rm -it --entrypoint bash mtlynch/picoshare:1.4.2

# /app/litestream restore -v -if-replica-exists 
database path or replica URL required

I have not provided the argument, this is expected behavior.

Error version:

• docker run --rm -it --entrypoint bash mtlynch/picoshare:1.4.3

# /app/litestream restore -v -if-replica-exists
flag provided but not defined: -v

The restore command recovers a database from a previous snapshot and WAL.

Usage:

	litestream restore [arguments] DB_PATH

	litestream restore [arguments] REPLICA_URL

Arguments:

	-config PATH
	    Specifies the configuration file.
	    Defaults to /etc/litestream.yml

	-no-expand-env
	    Disables environment variable expansion in configuration file.

	-replica NAME
	    Restore from a specific replica.
	    Defaults to replica with latest data.

	-generation NAME
	    Restore from a specific generation.
	    Defaults to generation with latest data.

	-index NUM
	    Restore up to a specific hex-encoded WAL index (inclusive).
	    Defaults to use the highest available index.

	-timestamp TIMESTAMP
	    Restore to a specific point-in-time.
	    Defaults to use the latest available backup.

	-o PATH
	    Output path of the restored database.
	    Defaults to original DB path.

	-if-db-not-exists
	    Returns exit code of 0 if the database already exists.

	-if-replica-exists
	    Returns exit code of 0 if no backups found.

	-parallelism NUM
	    Determines the number of WAL files downloaded in parallel.
	    Defaults to 8

	-v
	    Verbose output.


Examples:

	# Restore latest replica for database to original location.
	$ litestream restore /path/to/db

	# Restore replica for database to a given point in time.
	$ litestream restore -timestamp 2020-01-01T00:00:00Z /path/to/db

	# Restore latest replica for database to new /tmp directory
	$ litestream restore -o /tmp/db /path/to/db

	# Restore database from latest generation on S3.
	$ litestream restore -replica s3 /path/to/db

	# Restore database from specific generation on S3.
	$ litestream restore -replica s3 -generation xxxxxxxx /path/to/db

2024/06/05 23:36:53 ERROR failed to run error="flag provided but not defined: -v"

This is odd because the output indicates that -v is a valid flag.

I suspect this could be an upstream issue but wanted to flag it here first.

Dan

[mtlynch]

@danielmichaels - Thanks for the heads up!

It looks like it was a breaking change in Litestream that I missed:

benbjohnson/litestream#517

Fix should just be to remove the -v flag from the script.

[mtlynch]

Fixed in #574