-
Notifications
You must be signed in to change notification settings - Fork 0
add Pangle to app-ads.txt #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the app-ads.txt
file to include new authorized digital sellers, enhancing transparency and compliance for ad inventory within the application ecosystem.
Highlights
- Ad Partner Integration: Added Pangle as a direct authorized digital seller and PubMatic as a reseller to the
app-ads.txt
file.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two entries to the app-ads.txt
file: one for Pangle and one for Pubmatic. The entries themselves are correctly formatted according to the IAB app-ads.txt
specification. My review includes two suggestions aimed at improving file maintainability and adherence to common conventions:
- Ensure the file ends with a newline character. This is a standard text file convention that improves compatibility with various tools.
- Sort the new entries alphabetically within the file and group entries for the same domain. This enhances readability and makes the file easier to manage over time.
These suggestions are based on common best practices for app-ads.txt
files and general text file management, as no specific style guide was provided for this repository.
app-ads.txt
Outdated
pangleglobal.com,5024252,DIRECT | ||
pubmatic.com,161490,RESELLER,5d62403b186f2ace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For enhanced maintainability and readability, app-ads.txt
entries are conventionally sorted alphabetically by domain name. When multiple entries exist for the same domain, they are typically grouped together. While not a strict requirement of the IAB specification, this practice greatly helps in managing and verifying the file, especially as it grows.
Please consider relocating these new entries:
pangleglobal.com,5024252,DIRECT
(line 414) should be placed alphabetically. Based on the current file, this would be after theonetag.com
entries (e.g., after line 201) and beforeonlinemediasolutions.com
.pubmatic.com,161490,RESELLER,5d62403b186f2ace
(line 415) should be grouped with otherpubmatic.com
entries (currently lines 224-263). If also sorting by publisher ID within this group, it would fit afterpubmatic.com,161372,...
(line 254) and beforepubmatic.com,161748,...
(line 255).
https://www.pangleglobal.com/integration/app-ads-txt