Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide better error response when template parsing fails #3

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Provide better error response when template parsing fails #3

merged 1 commit into from
Jan 10, 2022

Conversation

ThaNarie
Copy link
Contributor

Add a wrapper around the export to catch errors and output the template
where the error happened.

Also add basic unit tests.

Example error:

    Error parsing muban template. Most likely, your html template is malformed.

    The template that gave the error is:
    <div data-test="${}"<span>foo</span></div>

fixes #2

@ThaNarie
Provide better error response when template parsing fails
c385eff 
Add a wrapper around the export to catch errors and output the template
where the error happened.

Also add basic unit tests.
@ThaNarie ThaNarie requested review from ThijsTyZ and psimk January 10, 2022 13:34
@ThaNarie ThaNarie merged commit 618c4bd into main Jan 10, 2022
@ThaNarie ThaNarie deleted the feature/htm-parse-error branch January 10, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psimk psimk psimk approved these changes

@ThijsTyZ ThijsTyZ Awaiting requested review from ThijsTyZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide better error response when template parsing fails
2 participants
@ThaNarie @psimk