Updates the h function to allow falsy values on data attributes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jspolancor
commented
Feb 28, 2022
jspolancor
commented
- Updates the h function to allow false values on data attributes
- Creates the cleanFalsyBooleans function to mutate html props
- Updates tests to reflect the changes
Creates the cleanFalsyBooleans to mutate html props
4 tasks
ThaNarie
requested changes
Feb 28, 2022
There was a problem hiding this comment.
Besides the small comments, I would like to mention:
- The commit messages are written in the wrong "tense" (
updatesshould beupdate) - I'm missing the updated
README(as specified in the task list of the original ticket). - It would also be nice to have an accompanied PR on the muban repo to update the docs.
src/lib/mtl.ts
Outdated
| export function cleanFalsyBooleans(props: Record<string, any>): Record<string, any> { | ||
| const stringifiedProps = { ...props }; | ||
|
|
||
| Object.entries(stringifiedProps).forEach(([key, value]) => { |
There was a problem hiding this comment.
I think a .entries > .map > .fromEntries is a bit nicer here (instead of the stringifiedProps mutation inside the loop`
src/lib/mtl.ts
Outdated
| /** | ||
| * Function to turn falsy boolean prop values to the string 'false' | ||
| */ | ||
| export function cleanFalsyBooleans(props: Record<string, any>): Record<string, any> { |
There was a problem hiding this comment.
unknown instead of any would probably work here as well.
src/lib/mtl.ts
Outdated
|
|
||
| return vhtml(type, props, children); | ||
| // If more prop modifier functions like cleanFalsyBooleans are added we could pipe them here | ||
| const mutatedProps = cleanFalsyBooleans(props); |
There was a problem hiding this comment.
Maybe naming wise, something like this?
processFalsyBooleanPropsprocessedProps
The Readme was updated, I'll create the PR to the muban repo in a moment |
ThaNarie
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.