chore: stream errors while streaming SSE #6160
Conversation
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| var buf bytes.Buffer | ||
| enc := json.NewEncoder(&buf) | ||
| enc.Encode(ev) |
Check warning
Code scanning / gosec
Errors unhandled Warning
| log.Debug().Msgf("Sending chunk failed: %v", err) | ||
| input.Cancel() | ||
| } | ||
| w.Flush() |
Check warning
Code scanning / gosec
Errors unhandled Warning
| } | ||
| respData, _ := json.Marshal(resp) | ||
|
|
||
| w.WriteString(fmt.Sprintf("data: %s\n\n", respData)) |
Check warning
Code scanning / gosec
Errors unhandled Warning
| respData, _ := json.Marshal(resp) | ||
|
|
||
| w.WriteString(fmt.Sprintf("data: %s\n\n", respData)) | ||
| w.WriteString("data: [DONE]\n\n") |
Check warning
Code scanning / gosec
Errors unhandled Warning
|
|
||
| w.WriteString(fmt.Sprintf("data: %s\n\n", respData)) | ||
| w.WriteString("data: [DONE]\n\n") | ||
| w.Flush() |
Check warning
Code scanning / gosec
Errors unhandled Warning
| } | ||
| var buf bytes.Buffer | ||
| enc := json.NewEncoder(&buf) | ||
| enc.Encode(ev) |
Check warning
Code scanning / gosec
Errors unhandled Warning
|
|
||
| log.Debug().Msgf("Sending chunk: %s", buf.String()) | ||
| fmt.Fprintf(w, "data: %v\n", buf.String()) | ||
| w.Flush() |
Check warning
Code scanning / gosec
Errors unhandled Warning
| } | ||
| log.Error().Msgf("Stream ended with error: %v", err) | ||
| fmt.Fprintf(w, "data: %v\n", "Internal error: "+err.Error()) | ||
| w.Flush() |
Check warning
Code scanning / gosec
Errors unhandled Warning
Description
Otherwise these are silently absorbed in the background
Notes for Reviewers
Signed commits