can remove the CacheTable #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
Jul 31, 2019
cache.go
Outdated
| // since we remove it, its cache is unnecessary ao we flush it. | ||
| cacheTable := cache[table] | ||
| if cacheTable != nil { | ||
| cacheTable.Flush() |
There was a problem hiding this comment.
Is flushing really necessary here? If we drop the last reference to the table, the GC should clean up those values for us.
There was a problem hiding this comment.
Yes. It should be unnecessary. I remember it is trick for java that can release those objects as early as possible, but I think it should be unnecessary for go.
|
@smallnest Careful, you keep pushing more commits to this branch, with seemingly unrelated changes. Please keep PRs & commits as granular as possible, so it's easier to review & merge them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we also flush before remove it