unicode support for stream metadata #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Leandros: Thanks! Looks good to me. What is the purpose of the changes in FreeStreamerDesktop/Base.lproj/MainMenu.xib? If no purpose, could you please re-create the pull request without the changes in the .xib and I could merge it. |
|
Oh, oops. ;) |
|
Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses wide strings (std::wstring) instead of narrow strings (std::string).
Not the most ideal implementation, could've used ICU or libiconv, though. Unfortunately both require a lot more effort to get it working on iOS.