Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Joy Frames X web blocks template #37203

Merged
merged 18 commits into from
May 11, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 8, 2023

Preview: https://deploy-preview-37203--material-ui.netlify.app/joy-ui/getting-started/templates/framesx-web-blocks/

Spent a few hours on the plane from San Francisco to Thailand (I just could not fall asleep the whole flight 🤣).


@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label May 8, 2023
@mui-bot
Copy link

mui-bot commented May 8, 2023

Netlify deploy preview

https://deploy-preview-37203--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against f28a666

@siriwatknp siriwatknp requested review from danilo-leal and a team May 9, 2023 02:27
@siriwatknp siriwatknp marked this pull request as ready for review May 9, 2023 02:27
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, cool hero sections! What a productive flight, huh 😅

An idea, inspired by this PR: we should probably add a filter (in the form of a tab, or a select dropdown) that allows readers to toggle the templates that were designed by us and those that are from 3rd parties. As we continue to add the latter, and whenever we get steam with adding more of our own, that filter will be helpful to improve the navigation experience there. What do you think?

@siriwatknp
Copy link
Member Author

An idea, inspired by this PR: we should probably add a filter (in the form of a tab, or a select dropdown) that allows readers to toggle the templates that were designed by us and those that are from 3rd parties. As we continue to add the latter, and whenever we get steam with adding more of our own, that filter will be helpful to improve the navigation experience there. What do you think?

Good point! which point (how many templates) do you think we should add that toggle?

@siriwatknp siriwatknp merged commit 845f795 into mui:master May 11, 2023
@danilo-leal
Copy link
Contributor

I don't have any magic number at the top of my head... I'd be down to do it now already! What do you think? No prob to wait a bit longer, too.

@siriwatknp
Copy link
Member Author

I don't have any magic number at the top of my head... I'd be down to do it now already! What do you think? No prob to wait a bit longer, too.

I'd say let's do it when we have the next template.

binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants