-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Joy Frames X web blocks template #37203
Conversation
Netlify deploy previewhttps://deploy-preview-37203--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, cool hero sections! What a productive flight, huh 😅
An idea, inspired by this PR: we should probably add a filter (in the form of a tab, or a select dropdown) that allows readers to toggle the templates that were designed by us and those that are from 3rd parties. As we continue to add the latter, and whenever we get steam with adding more of our own, that filter will be helpful to improve the navigation experience there. What do you think?
Good point! which point (how many templates) do you think we should add that toggle? |
I don't have any magic number at the top of my head... I'd be down to do it now already! What do you think? No prob to wait a bit longer, too. |
I'd say let's do it when we have the next template. |
Preview: https://deploy-preview-37203--material-ui.netlify.app/joy-ui/getting-started/templates/framesx-web-blocks/
Spent a few hours on the plane from San Francisco to Thailand (I just could not fall asleep the whole flight 🤣).