-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] More space for theme builder #38532
Conversation
Netlify deploy previewhttps://deploy-preview-38532--material-ui.netlify.app/ Bundle size report |
@oliviertassinari I feel like we could've discussed this more clearly! 😬 I think more about it as a "non-prioritized big opportunity" ⎯ we haven't yet aligned on committing full force to it, even though I agree with all your suggestions. It might be something to discuss further to understand what we prioritize regarding tooling for building with Material UI/Joy UI. How about we keep evolving this topic, getting @zanivan's shaping doc as a foundation, so we're all on the same page? |
Agree, feel like we should start from the design discussion first. |
I like this a lot, however, I feel we can explore some ideas and scenarios before committing into this. I left some thoughts on the shaping doc that really resonate with the points here, but I'd love more people joining the discussion. |
A least, what seems very clear to me as constraints for https://www.notion.so/Joy-UI-theme-builder-baeb2344a9a34b6ebd6c453a6bf3aa9b and Material UI (almost the same):
|
Give more space for https://mui.com/joy-ui/customization/theme-builder/.
Preview https://deploy-preview-38532--material-ui.netlify.app/joy-ui/customization/theme-builder/
In hindsight, compared to https://www.radix-ui.com/themes/playground and https://ui.shadcn.com/themes, it feels like we missed the product priority. This demo feels too advanced, not too far from the point where the persona it targets would prefer to do this in code or in Figma. I think the more important use case is quick high-level customization. And the most important: how do you even know if these values make sense? I think Developers should be able to better previous how values impact the look of the components.
So, I would be in favor of:
We would also have the Figma theme editor that @DavidCnoops is working on, but it's for advanced use cases. I think here the goal is when you create a side project, and internal tools (50% of the use cases?) you don't care so much, you want a quick easy way to customize the look & feel.