-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Use the @mui/internal-markdown package #12105
Conversation
Deploy preview: https://deploy-preview-12105--material-ui-x.netlify.app/ |
828644b
to
98e725d
Compare
98e725d
to
33d7390
Compare
Did you check when |
@flaviendelangle it come from this modification in https://github.com/mui/material-ui/pull/39137/files#r1501919356 Seems |
OK so we will have to bump the peer deps right? |
I did the update mostly to know if it would let the CI pass. I can see two other potential solution:
|
We will need to bump the dep to have https://mui-org.slack.com/archives/C0170JAM7ML/p1708507188557689?thread_ts=1708502628.309269&cid=C0170JAM7ML Just if we can make sure that we also have the PR of the Slack discussion (mui/material-ui#41219) in it |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@flaviendelangle Why is it blocking stable release? I worked on it because it was blocking #12188 and some other PR of docs-infra but nothing related to stable release |
The |
AFAIK we consider that bumping the version of our And as mentionned in #12105 (comment), we need to bump it to have access to mui/material-ui#41219 which is require to write clean code that is compatible with both PigmentCSS and System. But right now we can't bump it because of the broken type you mentioned So we have basically 3 solutions:
|
packages/x-data-grid/src/components/cell/GridEditSingleSelectCell.tsx
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Update: pr which aimed to solve SelectProps typing issue is merged |
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: alexandre <alex.fauquette@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
This PR contains the following updates:
^5.0.0-beta.36
->^5.0.0-beta.39
^5.15.9
->^5.15.13
^5.0.0-beta.27
->^5.0.0-beta.31
^5.0.0-alpha.165
->^5.0.0-alpha.168
^5.15.9
->^5.15.13
^5.15.9
->^5.15.13
^5.15.9
->^5.15.13
^5.15.9
->^5.15.13
Release Notes
mui/material-ui (@mui/base)
v5.0.0-beta.37
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.