Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Use the @mui/internal-markdown package #12105

Merged
merged 27 commits into from
Mar 20, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 18, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@mui/base (source) ^5.0.0-beta.36 -> ^5.0.0-beta.39 age adoption passing confidence
@mui/icons-material (source) ^5.15.9 -> ^5.15.13 age adoption passing confidence
@mui/joy (source) ^5.0.0-beta.27 -> ^5.0.0-beta.31 age adoption passing confidence
@mui/lab (source) ^5.0.0-alpha.165 -> ^5.0.0-alpha.168 age adoption passing confidence
@mui/material (source) ^5.15.9 -> ^5.15.13 age adoption passing confidence
@mui/styles (source) ^5.15.9 -> ^5.15.13 age adoption passing confidence
@mui/system (source) ^5.15.9 -> ^5.15.13 age adoption passing confidence
@mui/utils (source) ^5.15.9 -> ^5.15.13 age adoption passing confidence

Release Notes

mui/material-ui (@​mui/base)

v5.0.0-beta.37


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Feb 18, 2024
@mui-bot
Copy link

mui-bot commented Feb 18, 2024

Deploy preview: https://deploy-preview-12105--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8fd450c

@renovate renovate bot force-pushed the renovate/mui-core branch 4 times, most recently from 828644b to 98e725d Compare February 24, 2024 22:00
@flaviendelangle
Copy link
Member

Did you check when BaseSelectProps was introduced?
We have a very recent peer dep on the core deps so we should be fine

@alexfauquette
Copy link
Member

alexfauquette commented Feb 28, 2024

@flaviendelangle it come from this modification in @mui/material

https://github.com/mui/material-ui/pull/39137/files#r1501919356

Seems SelectProps mostly got renamed BaseSelectProps

@flaviendelangle
Copy link
Member

OK so we will have to bump the peer deps right?
Otherwise, people installing v5.15.0 will have an error.

@alexfauquette
Copy link
Member

I did the update mostly to know if it would let the CI pass. I can see two other potential solution:

  • The core team fix the breaking change such that SelectProps doe snot require variant anymore
  • We define our own SelectProps in the data grid such that it does not require variant

@flaviendelangle
Copy link
Member

We will need to bump the dep to have https://mui-org.slack.com/archives/C0170JAM7ML/p1708507188557689?thread_ts=1708502628.309269&cid=C0170JAM7ML
So I think it's fine doing it now 👌

Just if we can make sure that we also have the PR of the Slack discussion (mui/material-ui#41219) in it

Copy link
Contributor Author

renovate bot commented Feb 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

github-actions bot commented Mar 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 2, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 5, 2024
@alexfauquette
Copy link
Member

@flaviendelangle Why is it blocking stable release? I worked on it because it was blocking #12188 and some other PR of docs-infra but nothing related to stable release

@LukasTy
Copy link
Member

LukasTy commented Mar 14, 2024

Why is it blocking stable release?

The @mui/material peer dependency version bump. 🤔

@flaviendelangle
Copy link
Member

AFAIK we consider that bumping the version of our @mui/material peer dependency is a breaking change because people with a pinned version that is between the current peer dependency version and the new one would end up with 2 version of @mui/material bundled.

And as mentionned in #12105 (comment), we need to bump it to have access to mui/material-ui#41219 which is require to write clean code that is compatible with both PigmentCSS and System.

But right now we can't bump it because of the broken type you mentioned

So we have basically 3 solutions:

  1. The core fix before the major, we bump the peer dep
  2. The core does not fix before the major, we bump the peer dep after the major and ignore the fairly small BC
  3. The core does not fix before the major, we stick with the current peer dep and clear the styled core on the next major

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 14, 2024
@sai6855
Copy link
Contributor

sai6855 commented Mar 14, 2024

Update: pr which aimed to solve SelectProps typing issue is merged

mui/material-ui#41405 (comment)

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 15, 2024
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@renovate renovate bot changed the title Bump MUI Core Bump MUI Core - abandoned Mar 19, 2024
Copy link
Contributor Author

renovate bot commented Mar 19, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@alexfauquette alexfauquette changed the title Bump MUI Core - abandoned Bump MUI Core Mar 19, 2024
@renovate renovate bot changed the title Bump MUI Core Bump MUI Core - abandoned Mar 19, 2024
@flaviendelangle flaviendelangle changed the title Bump MUI Core - abandoned Bump MUI Core Mar 20, 2024
@LukasTy LukasTy removed this from the 7.0.0 milestone Mar 20, 2024
@alexfauquette alexfauquette merged commit 0b3a64d into next Mar 20, 2024
17 checks passed
@alexfauquette alexfauquette deleted the renovate/mui-core branch March 20, 2024 09:42
@LukasTy LukasTy changed the title Bump MUI Core [code-infra] Use the @mui/internal-markdown package Mar 20, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: alexandre <alex.fauquette@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants