-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jscodeshift to 0.15.2 #12305
Bump jscodeshift to 0.15.2 #12305
Conversation
Deploy preview: https://deploy-preview-12305--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2996bdf
to
4e9cb38
Compare
f20f924
to
d1f1ce2
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
d1f1ce2
to
72f50d5
Compare
72f50d5
to
0ba9d1f
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
0ba9d1f
to
6643fb7
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
6643fb7
to
f3fe2c3
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
f3fe2c3
to
55ec6c6
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
55ec6c6
to
6a5f809
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
48420ac
to
a8ce611
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
a8ce611
to
ff78388
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Following the same route as core, until the underlying issue with the recast is still there, let's not prevent our users from using latest typescript expressions like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this! 🙏
Core is releasing it under a new major, but in our case, this would end up in a minor/patch release. 🙈
WDYT about improving the documentation and also thinking about an informative changelog highlight to along with it.
Adding an additional runtime warning just like we already have might also be a good idea:
mui-x/packages/x-codemod/src/codemod.ts
Lines 68 to 75 in b38bef8
IMPORTANT NOTICE ABOUT CODEMOD USAGE | |
==================================== | |
Not all use cases are covered by codemods. In some scenarios, like props spreading, cross-file dependencies and etc., the changes are not properly identified and therefore must be handled manually. | |
For example, if a codemod tries to rename a prop, but this prop is hidden with the spread operator, it won't be transformed as expected. | |
<DatePicker {...pickerProps} /> | |
After running the codemods, make sure to test your application and that you don't have any console errors. |
WDYT @MBilalShafi? 🤔
Nice point. Do you mean it's kind-of a breaking change? It might be considered a non-breaking change, because:
Makes sense?
How about improving the existing one to accommodate this one too? - After running the codemods, make sure to test your application and that you don't have any console errors.
+ After running the codemods, make sure to test your application and that you don't have any errors. Or - After running the codemods, make sure to test your application and that you don't have any console errors.
+ After running the codemods, make sure to test your application and that you don't have any formatting or console errors. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think?
I'm sorry for the late reply @MBilalShafi.
Your comments/points make complete sense.
I do agree with all of them, I just wanted to be extra careful. 🙈 😆
But moving forward with this is more important than a few potential questions from some users. 👍
In regards to your suggestion, the second proposal for the message looks better to me. 👍
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
This PR contains the following updates:
Fixes #12567
0.13.1
->0.15.2
^0.11.5
->^0.11.11
Release Notes
facebook/jscodeshift (jscodeshift)
v0.15.2
Compare Source
Fixed
v0.15.1
Compare Source
Changed
@babel/plugin-proposal-private-methods
in worker (#568, @sibelius)Fixed
v0.15.0
Compare Source
Changed
Fixed
v0.14.0
Compare Source
Added
defineSnapshotTestFromFixture
test util (#471, @shriuken)renameTo
filters for Babel 6+ node types (#412 and #504, @elonvolo and @henryqdineen)childNodesOfType
to JSX traversal methods (#415, @j13huang)Changed
--help
to be listed in an order other than alphabetically, so they can instead be grouped thematically (#507, @elonvolo)j
shortcut in test utils (#515, @no23reason)Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.