-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use describeTreeView
for navigation tests
#12907
Merged
flaviendelangle
merged 8 commits into
mui:master
from
flaviendelangle:navigation-tree-view
May 17, 2024
Merged
[core] Use describeTreeView
for navigation tests
#12907
flaviendelangle
merged 8 commits into
mui:master
from
flaviendelangle:navigation-tree-view
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
Infrastructure work going on behind the scenes
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
labels
Apr 25, 2024
flaviendelangle
changed the title
[core] Use describeTreeView for navigation tests
[core] Use Apr 25, 2024
describeTreeView
for navigation tests
12 tasks
Deploy preview: https://deploy-preview-12907--material-ui-x.netlify.app/ |
LukasTy
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work! 👍👏
...w/src/internals/plugins/useTreeViewKeyboardNavigation/useTreeViewKeyboardNavigation.test.tsx
Outdated
Show resolved
Hide resolved
...w/src/internals/plugins/useTreeViewKeyboardNavigation/useTreeViewKeyboardNavigation.test.tsx
Outdated
Show resolved
Hide resolved
...w/src/internals/plugins/useTreeViewKeyboardNavigation/useTreeViewKeyboardNavigation.test.tsx
Outdated
Show resolved
Hide resolved
...w/src/internals/plugins/useTreeViewKeyboardNavigation/useTreeViewKeyboardNavigation.test.tsx
Outdated
Show resolved
Hide resolved
…Navigation/useTreeViewKeyboardNavigation.test.tsx Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
…Navigation/useTreeViewKeyboardNavigation.test.tsx Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
…Navigation/useTreeViewKeyboardNavigation.test.tsx Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
core
Infrastructure work going on behind the scenes
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12433
Second part of the keyboard navigation plugin. I just migrated the existing tests, I will add tests to check when some items are disabled but I'm waiting to make sure I'm not making any that already exists.
The next big chunk of work will be for the selection tests