Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use describeTreeView for navigation tests #12907

Merged
merged 8 commits into from
May 17, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 25, 2024

Part of #12433

Second part of the keyboard navigation plugin. I just migrated the existing tests, I will add tests to check when some items are disabled but I'm waiting to make sure I'm not making any that already exists.

The next big chunk of work will be for the selection tests

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 25, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 25, 2024
@flaviendelangle flaviendelangle changed the title [core] Use describeTreeView for navigation tests [core] Use describeTreeView for navigation tests Apr 25, 2024
@mui-bot
Copy link

mui-bot commented Apr 25, 2024

Deploy preview: https://deploy-preview-12907--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7c85462

@flaviendelangle flaviendelangle marked this pull request as ready for review April 25, 2024 15:10
@LukasTy LukasTy added the test label May 16, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work! 👍👏

flaviendelangle and others added 7 commits May 17, 2024 12:30
…Navigation/useTreeViewKeyboardNavigation.test.tsx

Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
…Navigation/useTreeViewKeyboardNavigation.test.tsx

Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
…Navigation/useTreeViewKeyboardNavigation.test.tsx

Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle flaviendelangle merged commit 31511a0 into mui:master May 17, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the navigation-tree-view branch May 17, 2024 11:57
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants