Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MUI Core #13000

Merged
merged 3 commits into from
May 29, 2024
Merged

Bump MUI Core #13000

merged 3 commits into from
May 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 5, 2024 •
edited by LukasTy
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@mui/icons-material (source) ^5.15.14 -> ^5.15.19 age adoption passing confidence
@mui/lab (source) ^5.0.0-alpha.169 -> ^5.0.0-alpha.170 age adoption passing confidence
@mui/material (source) ^5.15.14 -> ^5.15.19 age adoption passing confidence
@mui/styles (source) ^5.15.14 -> ^5.15.19 age adoption passing confidence
@mui/system (source) ^5.15.14 -> ^5.15.15 age adoption passing confidence

Release Notes

mui/material-ui (@​mui/icons-material)

v5.15.19

Compare Source

v5.15.18

Compare Source

May 14, 2024

A big thanks to the 5 contributors who made this release possible. Here are some highlights ✨:

@mui/material@5.15.18
Docs
Core

All contributors of this release in alphabetical order: @​arthurbalduini, @​oliviertassinari, @​samuelsycamore, @​TahaRhidouani, @​tarunrajput

v5.15.17

Compare Source

v5.15.16

Compare Source

mui/material-ui (@​mui/material)

v5.15.19

Compare Source

v5.15.18

Compare Source

May 14, 2024

A big thanks to the 5 contributors who made this release possible. Here are some highlights ✨:

@mui/material@5.15.18
Docs
Core

All contributors of this release in alphabetical order: @​arthurbalduini, @​oliviertassinari, @​samuelsycamore, @​TahaRhidouani, @​tarunrajput

v5.15.17

Compare Source

v5.15.16

Compare Source

mui/material-ui (@​mui/styles)

v5.15.19

Compare Source

v5.15.18

Compare Source

May 14, 2024

A big thanks to the 5 contributors who made this release possible. Here are some highlights ✨:

@mui/material@5.15.18
Docs
Core

All contributors of this release in alphabetical order: @​arthurbalduini, @​oliviertassinari, @​samuelsycamore, @​TahaRhidouani, @​tarunrajput

v5.15.17

Compare Source

May 8, 2024

A big thanks to the 4 contributors who made this release possible.
This release was mostly about 🐛 bug fixes and 📚 documentation improvements.

@mui/material@5.15.17
Docs
Core

All contributors of this release in alphabetical order: @​github-actions[bot], @​joserodolfofreitas, @​oliviertassinari, @​siriwatknp

v5.15.16

Compare Source

A big thanks to the 8 contributors who made this release possible. Here are some highlights ✨:
This release was mostly about 🐛 bug fixes and 📚 documentation improvements.

@mui/material@5.15.16
Docs
Core

All contributors of this release in alphabetical order: @​aarongarciah, @​alexfauquette, @​DanailH, @​DiegoAndai, @​github-actions[bot], @​JCQuintas, @​mnajdova, @​oliviertassinari

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label May 5, 2024
@mui-bot
Copy link

mui-bot commented May 5, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13000--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against da9c645

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 8, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 8, 2024
@renovate renovate bot force-pushed the renovate/mui-core branch 2 times, most recently from 4780159 to 18d4d04 Compare May 8, 2024 12:57
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 13, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 13, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 15, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 28, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 29, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
LukasTy
LukasTy reviewed May 29, 2024
View reviewed changes
pnpm-lock.yaml Outdated
@@ -3778,8 +3803,8 @@ packages:
- supports-color
- utf-8-validate

/@mui/joy@5.0.0-beta.32(@emotion/react@11.11.4)(@emotion/styled@11.11.5)(@types/react@18.2.60)(react-dom@18.2.0)(react@18.2.0):
resolution: {integrity: sha512-QJW5Mu2GTJUX4sXjxt4nQBugpJAiSkUT49S/bwoKCCWx8bCfsEyplTzZPK+FraweiGhGgZWExWOTAPpxH83RUQ==}
/@mui/joy@5.0.0-beta.36(@emotion/react@11.11.4)(@emotion/styled@11.11.5)(@types/react@18.2.60)(react-dom@18.2.0)(react@18.2.0):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joy package is still released as a beta, but on the same major.
I'm not a fan of the resulting effect of having certain @mui packages from v6 when it's technically not needed and could even cause issues, until we are not supporting it.
Going to add @mui/joy to ignore list to avoid it from being bumped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the resulting effect of having certain @mui packages from v6 when it's technically not needed

Can you elaborate? We don't seem to use v6 packages of MUI Core

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from beta-33 @mui/joy uses v6 internals: https://unpkg.com/@mui/joy@5.0.0-beta.36/package.json
I should have left a comment on a section of the lock file to preserve that information. 🙈

@renovate Renovate
Copy link
Contributor Author

renovate bot commented May 29, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@LukasTy LukasTy requested a review from a team May 29, 2024 15:00
@LukasTy LukasTy merged commit 2a288b9 into master May 29, 2024
17 checks passed
@LukasTy LukasTy deleted the renovate/mui-core branch May 29, 2024 20:33
This was referenced Jun 17, 2024
Merged
Closed
@LukasTy LukasTy mentioned this pull request Jul 15, 2024
Merged
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@renovate @LukasTy @DungTiger
Bump MUI Core (mui#13000)
efa4eee 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@renovate @LukasTy @thomasmoon
Bump MUI Core (mui#13000)
d931d38 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii left review comments

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
dependencies Update of dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mui-bot @flaviendelangle @LukasTy @cherniavskii