Enable/Disable Logger: SDK logs can be turned on or off from config #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now users can turn on or off the logger in SDK.
muke1908
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Thanks for your PR!
can you also please add it the Readme?
https://github.com/muke1908/chat-e2ee/tree/master/service#usage
Readme updated on how to enable/disable logging for users in sdk
muke1908
reviewed
Jun 23, 2023
service/src/utils/logger.ts
Outdated
| @@ -19,6 +21,11 @@ export class Logger { | |||
| } | |||
|
|
|||
| public log(...args: any[]) { | |||
| if(!configContext().settings.disableLog) { | |||
There was a problem hiding this comment.
Probably better to put it in the constructor. This will be evaluated every time the log is called.
There was a problem hiding this comment.
Got it. Thanks for the suggestion.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now users can turn on or off the logger in SDK.