docs: add dnsaddr protocol spec #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to the best of my knowledge. Added as separate doc in `protocols` dir so existing link in README becomes not 404 :)
jacobheun
reviewed
Nov 11, 2019
lidel
approved these changes
Nov 11, 2019
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
raulk
approved these changes
Nov 11, 2019
jacobheun
approved these changes
Nov 11, 2019
|
fun note: we had to add the 2 levels of indirection because we couldn't fit 8 records (ip4 & ip6 per boostrap node) into a single udp packet for the dns response https://github.com/protocol/bifrost-infra/issues/338 |
|
@olizilla mind adding a PR against |
Stebalien
reviewed
Nov 11, 2019
| @@ -0,0 +1,38 @@ | |||
| # `dnsaddr` | |||
There was a problem hiding this comment.
This should probably explain suffix matching: Given the address /dnsaddr/bootstrap.libp2p.io/SOMETHING, this address will only resolve to multiaddrs that end with SOMETHING.
olizilla
added a commit
that referenced
this pull request
Nov 12, 2019
includes - dnsaddr suffix matching - caveat about max udp dns response size see: #102 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
olizilla
added a commit
that referenced
this pull request
Nov 12, 2019
includes - dnsaddr suffix matching - caveat about max udp dns response size see: #102 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to the best of my knowledge.
Added as separate doc in
protocolsdir so existing link in README becomes not 404 :)