Menu fixes, rewrite garage opening code, minor tweaks #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colistro123
reviewed
May 6, 2025
| @@ -432,7 +432,7 @@ end | |||
| function RemovePlayerAttachedObject(amx, player, index) | |||
| local playerID = getElemID(player) | |||
| local obj = g_Players[playerID].attachedObjects[index] -- Get the object stored at this slot | |||
| if obj ~= nil and obj ~= false then | |||
colistro123
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it has all needed validity checks, also correctly working with nested menus (selecting an item won't produce exit event, but only selection event like SA-MP does, while exit event is only called when you really exit the menu via 'X' button or Enter key) and ofc now has its title rendered with the same means as the menu box itself, so it's a whole thing.
Here is how menus look now after all the corrections.
Garage opening code now uses appropriate events and checks using colsphere. This fixes #11
Some minor fixes for the recent changes