Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script load fail messages no longer pass to onDebugMessage #639

Closed
ArranTuna opened this issue Oct 7, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ArranTuna
Copy link
Contributor

commented Oct 7, 2018

Describe the bug
When a script fails to load, onDebugMessage does not trigger with the info even though it used to and it does show up in debug script.

To reproduce

  1. /debugscript 3
  2. srun addEventHandler("onDebugMessage", root, function(msg, lvl, file, line) outputDebugString("you won't see this") end)
  3. Add something like ==== to any script and restart it.
  4. Observe a ERROR in debugscript but no debug message saying "you won't see this".

Expected behaviour
I'm certain that this used to appear because I have a script that logs debugs to a web page and on IRC chat and so I could do scripting from IRC and would see load fails but now I don't see the load fails any more.

Version
Server v1.5.6-release-14414

Additional context

@ArranTuna ArranTuna added the bug label Oct 7, 2018

@botder botder closed this in 81b64e3 Oct 7, 2018

@botder

This comment has been minimized.

Copy link
Member

commented Oct 7, 2018

I hope the commit fixed the issue above.

@botder botder self-assigned this Oct 7, 2018

@botder botder added this to the 1.5.7 milestone Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.