-
-
Notifications
You must be signed in to change notification settings - Fork 479
Updated main menu's Arabic language pictures #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Haxardous
commented
Aug 11, 2019
- fixed their positioning & scale
- redone the translation
- fixed their positioning & scale - redone the translation
Please submit on https://translate.mtasa.com instead Thank you! |
Or actually we can still use this PR, it just needs submitting there as well! Just so that pootle is also up to date. |
all images on imgur // https://imgur.com/a/LcqC5S6 |
you mentioned in pm that you ran it through zoplinpng is the increase in size for Shared/data/MTA San Andreas/MTA/locale/ar/menu_disconnect.png and Shared/data/MTA San Andreas/MTA/locale/ar/menu_browse_servers.png intentional? |
I don't see any increase in filesize, only a decrease (as intended), but @Haxardous told me he intended to resize the image resolution in order to..
Note to @qaisjp: you wrote the same file name twice in your post above |
fixed
|
oh, I was mistaken as originally he demonstrated his improved images of which for example menu_disconnect was 6kb, which again got reduced to 2kb after running it through Zopflipng. But the original in MTA is 572 bytes. @Haxardous why don't you show the effect of your edits (like resize), so we can see if your resolution change is worth it for the visuals? |
it's probably fine, i just wanted to know if it's intentional |
ah, yes, since i discussed it with him i know it was intentional, since it happened in the process of improving the menu images.. anyways, here's a comparison (ingame screenshots) of appearance.. old: https://i.imgur.com/kaPc3aR.png new: https://i.imgur.com/qUPIYVX.png i personally think it looks much better.. maybe we need to get a second-opinion on the new translation quality (from other arabic speakers) as well |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
in that case it's fit to merge, but it's better to just let him reply since he has a voice too |
providing answers because i know them doesn't equal not letting him reply (he is free to do so), we are talking throughout the process of this PR, it's better not to make assumptions anyways, nice |
if the conversation didn't happen on the MTA discord, the conversation never happened |
I modified it's overall resolution for an accurate scaling (didn't changed the resolution pixels's width or height) to make it more clear: |
Sorry for late response, I was editing this in photoshop to make it more clear, my apologize. |
collaboration (in this case, helping someone with their PR) doesn't neccesarily have to be in public channels, if i dont want to credit myself on this contribution (i really didn't need to, as most work is from @Haxardous) - saying I am informed enough to comment what I know because of a collaboration should be sufficient for you not to do what you did - then it doesn't mean you incorrectly assuming things should break the peace/be rude in here.. that's all I was trying to say |
OK, I apologise for the rudeness here.
No, collaboration should be in public channels. I have repeated this several times, yet everyone still does it — collaboration and quality overall (project-wide) is worsened when it happens in PM. If someone contacts you in PM, and it's non-trivial + not security related, please try to encourage them to ask in #development instead. (This goes for everyone.) |
Obviously, I am perfectly happy to debate this. It's just that every time I say it, nobody objects |
alright, and i also have to admit that im mostly opposing this because we all know there's a problem between me and you, and I quickly believe it causes things like this
To be exact, there's no project guidelines that state you cannot help someone get small details in their PR ready, and it should be obvious this is also less relevant when it comes to non-changes (like this optimization of his work doesn't change anything that is perceived, and it's not code) But let's leave it here |