Element freezing changes #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not recreate object when changing frozen state - fixes frozen related crashes described in #8765 and looks better (object don't "blink"). Made setElementVelocity & setVehicleTurnVelocity return false if element is frozen.
|
Sorry to be a pain, but please separate these two changes to two separate pull requests. Also, any idea why the object was recreated in the first place? |
|
Because CEntitySA::SetStaticWaitingForCollision seems to be working only once. I close this and make 2 pull requests soon. |
|
Awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not recreate object when changing frozen state - fixes frozen related
crashes described in #8765 and looks better (object don't "blink").
Made clientside setElementVelocity & setVehicleTurnVelocity return false if element
is frozen (it does nothing already, so would be good to inform user there is no effect).