Skip to content

Conversation

ZReC
Copy link
Contributor

@ZReC ZReC commented Mar 24, 2017

@ZReC
Copy link
Contributor Author

ZReC commented Mar 24, 2017

I have researched how the foliage generation works, now, in addition to deactivating it, it eliminates waste.

@qaisjp
Copy link
Contributor

qaisjp commented Mar 24, 2017

Please add to setWorldSpecialPropertyEnabled

@ZReC ZReC changed the title is/setRandomFoliageEnabled (Client function) Add "randomfoliage" special property Mar 24, 2017
@jushar
Copy link
Contributor

jushar commented Mar 24, 2017

Don't worry about the whitespace changes in my merge commit. https://github.com/multitheftauto/mtasa-blue/pull/118/files?w=1 hides those changes.

The patch is good. However, its purpose collides a bit with CSettingsSA::SetGrassEnabled (which can be set in the video settings menu) as it also enables/disables grass. I'm fine with that, but someone else should approve it as well before merging it.

@qaisjp
Copy link
Contributor

qaisjp commented Mar 25, 2017

Is all random foliage just grass, or is grass a subset of random foliage?

@jushar
Copy link
Contributor

jushar commented Mar 25, 2017

It's a subset (cactuses are another example).

@ccw808
Copy link
Member

ccw808 commented Mar 25, 2017

I think this is ok because grass is part of GTA's FX quality settings, so should be user changeable.
Disabling cacti and rocks via scripting allows ground models to be used in different ways by mappers.

@ccw808 ccw808 self-requested a review March 25, 2017 21:33
@qaisjp qaisjp self-requested a review March 26, 2017 00:11
@ZReC
Copy link
Contributor Author

ZReC commented Mar 26, 2017

Well, thanks for considering these requests, I hope to be able to contribute more to this pleasant community!

@ccw808 ccw808 merged commit 16c8ac5 into multitheftauto:master Mar 26, 2017
@qaisjp qaisjp added the enhancement New feature or request label May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants