Skip to content

Fix #1174: accept team & table of players in outputChatBox #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2020
Merged

Fix #1174: accept team & table of players in outputChatBox #1213

merged 3 commits into from
Jan 21, 2020

Conversation

StrixG
Copy link
Contributor

@StrixG StrixG commented Jan 17, 2020

Closes #1174

@StrixG StrixG marked this pull request as ready for review January 18, 2020 09:35
@StrixG StrixG changed the title Accept a table of players in outputChatBox Accept a table of players and team element in outputChatBox Jan 18, 2020
@Citizen01 Citizen01 added the enhancement New feature or request label Jan 19, 2020
qaisjp
qaisjp approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@qaisjp qaisjp added this to the 1.6 milestone Jan 21, 2020
@qaisjp qaisjp changed the title Accept a table of players and team element in outputChatBox Fix #1174: accept team & table of players in outputChatBox Jan 21, 2020
@qaisjp qaisjp merged commit d2c53c7 into multitheftauto:master Jan 21, 2020
@StrixG StrixG deleted the feature/outputchatbox-sendlist branch January 23, 2020 21:55
@Dutchman101
Copy link
Member

Dutchman101 commented Jan 24, 2020 •
edited
Loading

This change breaks existing scripts, especially gamemodes: if there's a chathandler replacement (like freeroam has), all chat messages will be output twice if the player is in a team.

Issue #1223

@Citizen01
Copy link
Member

Mentionned #1223 issue now fixed in 24a233f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@qaisjp qaisjp qaisjp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.

outputChatBox - expand visibleTo possibility
4 participants
@StrixG @Dutchman101 @Citizen01 @qaisjp