Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #403: make colshapes cloneable #1214

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Fix #403: make colshapes cloneable #1214

merged 2 commits into from
Jan 21, 2020

Conversation

StrixG
Copy link
Contributor

@StrixG StrixG commented Jan 18, 2020 •
edited
Loading

Closes #403

  • Polygon points doesn't move when specifying a new position in cloneElement.

Test resource:
clone-colshapes.zip (Commands are cs and clone)

@Citizen01 Citizen01 added the enhancement New feature or request label Jan 19, 2020
qaisjp
qaisjp approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@qaisjp qaisjp changed the title Make col shapes cloneable Fix #403: make colshapes cloneable Jan 21, 2020
@qaisjp qaisjp merged commit c702fe4 into multitheftauto:master Jan 21, 2020
@qaisjp qaisjp added this to the 1.6 milestone Jan 21, 2020
@StrixG StrixG deleted the clone-colshapes branch January 23, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qaisjp qaisjp qaisjp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.

cloneElement can't clone colshapes
3 participants
@StrixG @qaisjp @Citizen01