Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloneElement can't clone colshapes #403

Closed
qaisjp opened this issue Sep 5, 2018 · 2 comments · Fixed by #1214
Closed

cloneElement can't clone colshapes #403

qaisjp opened this issue Sep 5, 2018 · 2 comments · Fixed by #1214
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.5.8

Comments

@qaisjp
Copy link
Contributor

qaisjp commented Sep 5, 2018 •
edited
Loading

Describe the solution you'd like
Write code so that cloneElement works on colshapes.

Additional context
Blocked by #182.
https://bugs.mtasa.com/view.php?id=8193
@qaisjp qaisjp added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2018
@qaisjp qaisjp added this to the Backlog milestone Sep 5, 2018
@patrikjuvonen
Copy link
Contributor

cc @emre1702

@qaisjp qaisjp mentioned this issue Sep 5, 2018
Open
@emre1702
Copy link
Contributor

emre1702 commented Sep 6, 2018 •
edited
Loading

Will do it later when I got enough time after adding the cloneElement method first (virtual method "clone" for elements).

@StrixG StrixG mentioned this issue Jan 18, 2020
Merged
1 task
qaisjp pushed a commit that referenced this issue Jan 21, 2020
@StrixG @qaisjp
Fix #403: make colshapes cloneable (#1214)
c702fe4 
* Make col shapes cloneable

* Fix col polygon cloning
@qaisjp qaisjp modified the milestones: Backlog, 1.6 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.5.8
Development

Successfully merging a pull request may close this issue.

Fix #403: make colshapes cloneable StrixG/mtasa-blue
3 participants
@qaisjp @emre1702 @patrikjuvonen