Add functions to manipulate colshapes parameters

[StrixG]

• Radius (circle, sphere, tube)

float getColShapeRadius(colshape colShape)
bool setColShapeRadius(colshape colShape, float radius)

• Size

Tube (height)

float getColShapeSize(colshape colShape)
bool setColShapeSize(colshape colShape, float size)

Rectangle (width, height)

float, float getColShapeSize(colshape colShape)
bool setColShapeSize(colshape colShape, Vector2 size)
bool setColShapeSize(colshape colShape, float width, float height)

Cuboid (width, depth, height)

float, float, flaot getColShapeSize(colshape colShape)
bool setColShapeSize(colshape colShape, Vector3 size)
bool setColShapeSize(colshape colShape, float width, float depth, float height)

• Polygon points

table getColPolygonPoints(colshape colPolygon)
Vector2 getColPolygonPointPosition(colshape colPolygon, int pointIndex)
bool setColPolygonPointPosition(colshape colPolygon, int pointIndex, Vector2 position)
bool addColPolygonPoint(colshape colPolygon, Vector2 position[, int pointIndex])
bool removeColPolygonPoint(colshape colPolygon, int pointIndex)

[CrosRoad95]

you should also add heigth for polygons, #226

[StrixG]

Should I leave one setColShapeSize function or make three different functions to change parameters separately (setColShapeWidth, setColShapeHeight, setColShapeDepth)?

[PlatinMTA]

Should I leave one setColShapeSize function or make three different functions to change parameters separately (setColShapeWidth, setColShapeHeight, setColShapeDepth)?

I think setColShapeSize is alright, having to many functions just to change the size of the colshape would be confusing/annoying tbh. If the function adapts to the type of colshape it's changing that's all we need i think

[StrixG]

I'm not sure if I should use the sync time context here or not.

[qaisjp]

The code looks good to me.

I'm not sure if I should use the sync time context here or not.

I'm not sure either. Let's figure it out together.

I found this (introduced in initial commit):

// This is used for realtime synced elements. Whenever a position/rotation change is
// forced from the server either in form of spawn or setElementPosition/rotation a new
// value is assigned to this from the server. This value also comes with the sync packets.
// If this value doesn't match the value from the sync packet, the packet should be
// ignored. Note that if this value is 0, all sync packets should be accepted. This is
// so we don't need this byte when the element is created first.

Markers don't use a sync time context, so I'd guess that colshapes wouldn't need them either. What do you think?

[qaisjp]

have you tested the latest version?

[qaisjp]

I'm overall happy with this and can merge once comments have been addressed.

I don't have time to test, but I'm confident in your work, so I'll merge once you've confirmed you've tested the latest version

[StrixG]

These functions also allow you to edit colshapes of markers and pickups. Should I leave this opportunity?

Everything tested. Works good.

[qaisjp]

These functions also allow you to edit colshapes of markers and pickups.

That's funky. Let's leave it in!

[Dutchman101]

Warning C4018 '>=': signed/unsigned mismatch \mtasa-blue\Client\mods\deathmatch\logic\CClientColPolygon.cpp:80
Warning C4018 '>=': signed/unsigned mismatch\ mtasa-blue\Server\mods\deathmatch\logic\CColPolygon.cpp:96

@StrixG the point index should be unsigned int.. why would you use int? This adds new warnings to our list

[StrixG]

I use -1 as default value to add a point to the end of the list. I should have used static_cast on line 80.