Skip to content

Conversation

Necktrox
Copy link

Issue: #9629: onClientConsole should skip "login" command

This pull request solves the issue in the link above, but it doesn't protect players from malicious servers, which look for the /register command, which isn't hard-coded. There are obviously other ways to steal a player's password too.

@qaisjp qaisjp merged commit a381f24 into multitheftauto:master May 11, 2017
@qaisjp qaisjp added the bug Something isn't working label May 11, 2017
@Bonsai11
Copy link

Bonsai11 commented May 11, 2017

I'm not sure if its still possible today, but a few years ago you could create a clientside command handler with "login" as name and simply grab the parameters, which would be the username and password, and send them to a serverside script that outputs them to you. So whenever someone uses /login, you could get their passwords. This could be done by simple map scripts, only works while the map is running but due to people binding /login to a key you would still get a lot.

@Dezash
Copy link
Contributor

Dezash commented May 11, 2017

There is no point in trying to prevent servers from having your credentials. If you don't trust a service provider then you should not reuse the same password. However, this commit is useful for preventing someone from stealing your credentials if you are logging in on a public computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants