Function: isVehicleWheelCollided #146

ZReC · 2017-05-29T04:45:46Z

This function detect if car wheel is on air or in collision.

Example:
isVehicleWheelCollided ( theVehicle, "rear_left" )
or
isVehicleWheelCollided ( theVehicle, 1 )
or
theVehicle.isWheelCollided ( "front_right" )

The wheels are:

"front_left" or 0
"rear_left" or 1
"front_right" or 2
"rear_right" or 3

Bikes only have front / rear left wheel .

If someone has a better name for the function please comment 👍

This function detect if car wheel is on air or in collision. Example: isVehicleWheelCollided ( theVehicle, "rear_left" ) or isVehicleWheelCollided ( theVehicle, 1 ) The wheels are: "front_left" or 0 "rear_left" or 1 "front_right" or 2 "rear_right" or 3 Bikes only have front / rear left wheel . If someone has a better name for the function please comment 👍

Necktrox · 2017-05-29T15:33:46Z

Client/mods/deathmatch/logic/luadefs/CLuaVehicleDefs.cpp

+    if ( !argStream.HasErrors () )
+        lua_pushboolean ( luaVM, pVehicle->IsWheelCollided ( wheel ) );
+    else
+        lua_pushboolean ( luaVM, false );


m_pScriptDebugging->LogCustom ( luaVM, argStream.GetFullErrorMessage() ); is missing here

Necktrox · 2017-05-29T15:34:12Z

Client/mods/deathmatch/logic/luadefs/CLuaVehicleDefs.cpp

@@ -913,6 +915,20 @@ int CLuaVehicleDefs::GetVehicleWheelStates ( lua_State* luaVM )
    return 1;
 }

+int CLuaVehicleDefs::IsVehicleWheelCollided ( lua_State* luaVM )
+{
+    CClientVehicle* pVehicle = NULL; eWheels wheel;


Consider using nullptr instead of NULL

CrosRoad95 · 2017-05-29T17:58:41Z

Next can you add function getVehicleWheelContactMaterial(vehicle,wheel) it can be used for detect if player drive over grass

By Necktrox

Citizen01 · 2017-05-30T09:53:45Z

Client/mods/deathmatch/logic/luadefs/CLuaVehicleDefs.cpp

@@ -917,16 +917,17 @@ int CLuaVehicleDefs::GetVehicleWheelStates ( lua_State* luaVM )

 int CLuaVehicleDefs::IsVehicleWheelCollided ( lua_State* luaVM )
 {
-    CClientVehicle* pVehicle = NULL; eWheels wheel;
+    CClientVehicle* pVehicle = nullptr; eWheels wheel;
    CScriptArgReader argStream ( luaVM );
    argStream.ReadUserData ( pVehicle );
    argStream.ReadEnumStringOrNumber ( wheel );

    if ( !argStream.HasErrors () )
        lua_pushboolean ( luaVM, pVehicle->IsWheelCollided ( wheel ) );


You should return 1; right after that line, with that change.

Yes, I realized later
(I'm stupid..)

qaisjp · 2017-05-30T14:37:52Z

Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.cpp

+    ADD_ENUM ( REAR_LEFT_WHEEL,     "rear_left" )
+    ADD_ENUM ( FRONT_RIGHT_WHEEL,   "front_right" )
+    ADD_ENUM ( REAR_RIGHT_WHEEL,    "rear_right" )
+IMPLEMENT_ENUM_END ( "wheels" )


call it wheel-position instead

qaisjp · 2017-05-30T14:38:03Z

Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.cpp

@@ -492,6 +492,12 @@ IMPLEMENT_ENUM_BEGIN ( eCursorType )
    ADD_ENUM ( CURSORTYPE_SEG_SIZING,   "segment_sizing" )  // segment sizing cursor (note: not in use)
 IMPLEMENT_ENUM_END ( "cursor-type" )

+IMPLEMENT_ENUM_BEGIN ( eWheels )


eWheelPosition

Should I change the label of the enum?

qaisjp · 2017-05-30T14:43:00Z

I suggest the function is called doesVehicleWheelCollide or getVehicleWheelCollide.

Also, perhaps we should instead only support text arguments or number arguments. I lean towards only supporting text arguments. The simpler and easier to understand, the better. This is up for discussion.

eWheels to eWheelPosition

jushar · 2017-07-29T11:33:42Z

Could you please refactor CVehicleSA::IsWheelCollided to use the appropriate member attributes of CVehicleSAInterface instead of manual offset calculations.

E.g.:

bool CVehicleSA::IsWheelCollided(std::uint8_t wheelPosition) // eWheelPosition might also be better here
{
  CVehicleSAInterface* vehicle = GetInterface();
  switch (vehicle->wheelType) // or whatever this is exactly
  {
  case 0:
    if (wheelPosition < 4)
      return vehicle->wheelCollisionState[wheelPosition] == 4.0f;
  // ...
}

ZReC · 2017-07-29T21:19:42Z

Not a bad idea, I'll do my best.

CrosRoad95 · 2017-07-30T14:11:46Z

what if vehicle dont have 4 wheel? ex 3 ( dodo ) or motorbike ?

ZReC · 2017-07-30T23:53:31Z

In vehicles of 3 wheels are combined 2 in 1, in motorbikes only the left

ZReC · 2017-07-31T00:12:56Z

Jusonex, I have problems implementing the code to CVehicleSAInterface, it turns out that from offset 0x5A0 (1440 decimal) CVehicleSAInterface should give rise to a class more specific of the type of vehicle in particular (CAutomobile, CBike, CHeli, CTrain, CPlane) But instead the class extends with variables of different types of vehicles as of trains:

//1440
unsigned char m_ucTrackNodeID;  // Current node on train tracks

In my opinion would have to be rewritten this sector of the code, to make it more structured and manageable, meanwhile could graft the code of the collision but would not be the most appropriate.
What do you think?

Note: the offset 0x590 if it is the vehicle type, type uint8_t and its values correspond to:
0 = car - plane | 5 = boat | 6 = train | 9 = bike

jushar · 2017-07-31T17:35:35Z

In my opinion would have to be rewritten this sector of the code, to make it more structured and manageable

Yes, that's the way to go - not as a part of this PR though.

I'd say update as much as possible (e.g. 0x590) and leave the rest as it is.

CVehicleSAInterface size it was not according to offset of m_fBurningTime

ZReC · 2017-10-06T08:19:19Z

Updated. Excuse me for the lack of activity, studies are killing me 😆

ZReC added 5 commits March 26, 2017 07:49

Merge remote-tracking branch 'refs/remotes/multitheftauto/master'

89bdf10

Merge remote-tracking branch 'refs/remotes/multitheftauto/master'

cc48fb6

Merge remote-tracking branch 'refs/remotes/multitheftauto/master'

97ac7d6

Merge remote-tracking branch 'refs/remotes/multitheftauto/master'

125d589

ZReC changed the title ~~Feature/is vehicle wheel collided~~ Function: isVehicleWheelCollided May 29, 2017

Necktrox reviewed May 29, 2017

View reviewed changes

Necktrox added the enhancement New feature or request label May 29, 2017

Little change.

eecb384

By Necktrox

Citizen01 reviewed May 30, 2017

View reviewed changes

qaisjp reviewed May 30, 2017

View reviewed changes

ZReC added 2 commits May 30, 2017 14:40

Fix & change

88e66cc

Rename enum

8c34018

eWheels to eWheelPosition

Refactored code section

4a02d2c

CVehicleSAInterface size it was not according to offset of m_fBurningTime

Necktrox added the pr:needs-testing label Dec 10, 2017

Necktrox merged commit 192445b into multitheftauto:master Feb 16, 2018

Necktrox removed the pr:needs-testing label Feb 16, 2018

patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018

patrikjuvonen assigned botder Sep 4, 2018

Uh oh!

Function: isVehicleWheelCollided #146

Function: isVehicleWheelCollided #146

Uh oh!

Conversation

ZReC commented May 29, 2017

Uh oh!

Necktrox May 29, 2017

Choose a reason for hiding this comment

Uh oh!

Necktrox May 29, 2017

Choose a reason for hiding this comment

Uh oh!

CrosRoad95 commented May 29, 2017

Uh oh!

Citizen01 May 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZReC May 30, 2017

Choose a reason for hiding this comment

Uh oh!

qaisjp May 30, 2017

Choose a reason for hiding this comment

Uh oh!

qaisjp May 30, 2017

Choose a reason for hiding this comment

Uh oh!

ZReC May 30, 2017

Choose a reason for hiding this comment

Uh oh!

qaisjp May 31, 2017

Choose a reason for hiding this comment

Uh oh!

qaisjp commented May 30, 2017

Uh oh!

jushar commented Jul 29, 2017

Uh oh!

ZReC commented Jul 29, 2017

Uh oh!

CrosRoad95 commented Jul 30, 2017

Uh oh!

ZReC commented Jul 30, 2017

Uh oh!

ZReC commented Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jushar commented Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZReC commented Oct 6, 2017

Uh oh!

Uh oh!

Citizen01 May 30, 2017 •

edited

Loading

ZReC commented Jul 31, 2017 •

edited

Loading

jushar commented Jul 31, 2017 •

edited

Loading