Skip to content

Fix #1581: dxDrawPrimitive wrong colors with alpha <255 #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix #1581: dxDrawPrimitive wrong colors with alpha <255 #1595

merged 1 commit into from
Aug 5, 2020

Conversation

StrixG
Copy link
Contributor

@StrixG StrixG commented Aug 3, 2020 •
edited
Loading

Image

image

Test resource: primitivebug.zip

Fixes #1581

@StrixG StrixG added this to the 1.5.8 milestone Aug 3, 2020
@StrixG StrixG added the bug Something isn't working label Aug 3, 2020
qaisjp
qaisjp approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK but how come reading floats directly causes this issue?

@StrixG
Copy link
Contributor Author

StrixG commented Aug 3, 2020 •
edited
Loading

Seems OK but how come reading floats directly causes this issue?

¯\_(ツ)_/¯

static_cast<DWORD>(static_cast<int64_t>(float)) // not okay
static_cast<DWORD>(static_cast<int64_t>(double)) // works great

@StrixG StrixG merged commit c79a3ac into multitheftauto:master Aug 5, 2020
@StrixG StrixG deleted the bugfix/1581-primitive-colors branch August 5, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@qaisjp qaisjp qaisjp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.

dxDrawPrimitive* & dxDrawMaterialPrimitive* color bug
2 participants
@StrixG @qaisjp