Added new functions get/setObjectProperty #162

lex128 · 2017-10-08T09:07:01Z

Patch for https://bugs.mtasa.com/view.php?id=9740

CrosRoad95 · 2017-10-08T13:58:01Z

do this allow to enable physics for any object?

Einheit-101 · 2017-10-10T20:11:11Z

For me this looks like its just possible to edit some more physics properties of objects, but it doesnt magically convert a static object into a dynamic one.

lex128 · 2018-01-01T06:01:40Z

May be better a common function like vehicle handling

bool setObjectPhysics ( element theObject, string property, var value )

and

table getObjectPhysics ( element theObject )

qaisjp · 2018-01-01T21:49:06Z

Your suggestion is fantastic Lex.

How about prop getObjectProperty ( element theObject, string prop ). And a prop of "all" would return the table of all props?

Citizen01 · 2018-01-01T22:42:41Z

Client/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp

+
+bool CStaticFunctionDefinitions::SetObjectAirResistance ( CClientEntity& Entity, float fAirResistance )
+{
+    //if ( fAirResistance > 0.0f && fAirResistance <= 1.0f )


Do you plan to uncomment that out before pushing ? (same for elasticity ?)

I dont know yet how better

…perties

…mtasa-blue into feature/objectProperties # Conflicts: # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.cpp # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.h

…into feature/objectProperties # Conflicts: # Client/game_sa/CPhysicalSA.cpp # Client/game_sa/CPhysicalSA.h # Client/mods/deathmatch/logic/CClientObject.cpp # Client/mods/deathmatch/logic/CClientObject.h # Client/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp # Client/mods/deathmatch/logic/CStaticFunctionDefinitions.h # Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.cpp # Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.h # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.cpp # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.h # Client/sdk/game/CPhysical.h # Server/mods/deathmatch/logic/CResourceChecker.Data.h

lex128 · 2018-05-03T12:01:40Z

Done

bool  setObjectProperty(element theObject, string property, ...)
...   getObjectProperty(element theObject, string property)
table getObjectProperties(element theObject)

And how better "property" takes values?
as now like enum
"mass", "turn_mass", "air_resistance", "elasticity", "center_of_mass", "buoyancy"

or like vehicle handling
"mass", "turnMass", "airResistance", "elasticity", "centerOfMass", "buoyancy"

qaisjp · 2018-05-03T13:08:28Z

Like enum 👍

patrikjuvonen · 2018-09-05T00:28:47Z

Are these related?

Squashed commit of the following: commit 5f2a8005d43d2159bd7220f132e24f1619096a04 Author: Qais Patankar <qaisjp@gmail.com> Date: Thu Sep 6 11:04:07 2018 +0100 set fields to enumtostring value commit d970844 Author: Qais Patankar <qaisjp@gmail.com> Date: Thu Sep 6 10:59:49 2018 +0100 Fix oop commit 41d4155 Author: Qais Patankar <qaisjp@gmail.com> Date: Thu Sep 6 10:58:23 2018 +0100 Merge getObjectProperties in getObjectProperty commit 97b8b0f Author: Qais Patankar <qaisjp@gmail.com> Date: Thu Sep 6 10:21:20 2018 +0100 Reset CResourceChecker.Data.h commit 3fa2635 Author: Qais Patankar <qaisjp@gmail.com> Date: Thu Sep 6 10:17:36 2018 +0100 Fix formatting commit 24b5009 Merge: 5e04140 ea1dbae Author: Qais Patankar <qaisjp@gmail.com> Date: Thu Sep 6 10:05:42 2018 +0100 Merge branch 'next' into feature/objectProperties commit 5e04140 Merge: ff661b8 dc27d47 Author: Qais Patankar <qaisjp@gmail.com> Date: Wed Sep 5 03:02:27 2018 +0100 Merge branch 'master' into feature/objectProperties commit ff661b8 Author: Qais Patankar <qaisjp@gmail.com> Date: Sat Aug 4 22:53:02 2018 +0100 comment out deprecation and save it for later commit 5531b87 Author: Qais Patankar <qaisjp@gmail.com> Date: Sat Aug 4 22:51:54 2018 +0100 rem extra lines again commit 1c0d84e Author: Qais Patankar <qaisjp@gmail.com> Date: Sat Aug 4 22:50:54 2018 +0100 rem extra lines commit 9c57135 Merge: d4b5374 8da5f88 Author: Qais Patankar <qaisjp@gmail.com> Date: Sat Aug 4 22:49:19 2018 +0100 Merge branch 'master' into feature/objectProperties commit d4b5374 Merge: f015e8a 3924406 Author: Alexander <lexr128@gmail.com> Date: Mon Jul 23 13:43:40 2018 +0700 Merge branch 'master' into feature/objectProperties commit f015e8a Author: Alexander Lex128 <lexr128@gmail.com> Date: Thu May 3 00:37:23 2018 +0700 Clang format commit f4e0a28 Merge: b8bdc10 4b20544 Author: Alexander Lex128 <lexr128@gmail.com> Date: Wed May 2 23:43:00 2018 +0700 Merge branch 'master' of https://github.com/multitheftauto/mtasa-blue into feature/objectProperties # Conflicts: # Client/game_sa/CPhysicalSA.cpp # Client/game_sa/CPhysicalSA.h # Client/mods/deathmatch/logic/CClientObject.cpp # Client/mods/deathmatch/logic/CClientObject.h # Client/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp # Client/mods/deathmatch/logic/CStaticFunctionDefinitions.h # Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.cpp # Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.h # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.cpp # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.h # Client/sdk/game/CPhysical.h # Server/mods/deathmatch/logic/CResourceChecker.Data.h commit b8bdc10 Author: Alexander Lex128 <lexr128@gmail.com> Date: Wed May 2 23:15:29 2018 +0700 Deprecate get/setObjectMass commit b529577 Merge: cfe2644 14a1abb Author: Alexander Lex128 <lexr128@gmail.com> Date: Wed May 2 17:54:01 2018 +0700 Merge branch 'feature/objectProperties' of https://github.com/lex128/mtasa-blue into feature/objectProperties # Conflicts: # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.cpp # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.h commit cfe2644 Author: Alexander Lex128 <lexr128@gmail.com> Date: Wed May 2 17:43:21 2018 +0700 Combining functions commit 14a1abb Author: Marek Kulik <necktrox@gmail.com> Date: Mon Feb 26 15:31:35 2018 +0100 Tiny comment corrections commit d7bed51 Author: Marek Kulik <necktrox@gmail.com> Date: Mon Feb 26 15:10:45 2018 +0100 Return Vector3 in Object.centerOfMass commit d3b0b93 Merge: debd106 9f7117f Author: Marek Kulik <necktrox@gmail.com> Date: Mon Feb 26 10:45:28 2018 +0100 Merge remote-tracking branch 'upstream/master' into feature/objectProperties commit debd106 Merge: 1e01cdd 45185a6 Author: Marek Kulik <necktrox@gmail.com> Date: Sun Feb 25 13:18:39 2018 +0100 Merge remote-tracking branch 'upstream/master' into feature/objectProperties commit 1e01cdd Author: Alexander Lex128 <lexr128@gmail.com> Date: Fri Oct 13 22:51:32 2017 +0700 More correct OOP vars commit c084287 Author: Alexander Lex128 <lexr128@gmail.com> Date: Sun Oct 8 15:56:56 2017 +0700 Tabs commit b3c0e98 Merge: ab330f0 510990e Author: Alexander Lex128 <lexr128@gmail.com> Date: Sun Oct 8 00:03:21 2017 +0700 Merge branch 'master' into feature/objectProperties commit ab330f0 Author: lex128 <lexr128@gmail.com> Date: Tue Sep 13 18:23:24 2016 +0700 Added functions for object properties Co-authored-by: Qais Patankar <qaisjp@gmail.com>

qaisjp · 2018-09-06T10:15:27Z

sorry for the confusion, that last one should be the right one!

lex128 · 2018-09-06T13:17:44Z

It's not related @patrikjuvonen

lex128 added 3 commits September 13, 2016 18:23

Added functions for object properties

ab330f0

Merge branch 'master' into feature/objectProperties

b3c0e98

Tabs

c084287

More correct OOP vars

1e01cdd

Necktrox added the enhancement New feature or request label Nov 15, 2017

Necktrox added the pr:needs-testing label Dec 1, 2017

Citizen01 reviewed Jan 1, 2018

View reviewed changes

Marek Kulik added 4 commits February 25, 2018 13:18

Merge remote-tracking branch 'upstream/master' into feature/objectPro…

debd106

…perties

Merge remote-tracking branch 'upstream/master' into feature/objectPro…

d3b0b93

…perties

Return Vector3 in Object.centerOfMass

d7bed51

Tiny comment corrections

14a1abb

Necktrox added pr:tested and removed pr:needs-testing labels Feb 26, 2018

lex128 added 5 commits May 2, 2018 17:43

Combining functions

cfe2644

Merge branch 'feature/objectProperties' of https://github.com/lex128/…

b529577

…mtasa-blue into feature/objectProperties # Conflicts: # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.cpp # Client/mods/deathmatch/logic/luadefs/CLuaObjectDefs.h

Deprecate get/setObjectMass

b8bdc10

Clang format

f015e8a

botder added review-required and removed enhancement New feature or request labels Jul 9, 2018

qaisjp removed review required labels Jul 14, 2018

Merge branch 'master' into feature/objectProperties

d4b5374

qaisjp added 4 commits August 4, 2018 22:49

Merge branch 'master' into feature/objectProperties

9c57135

rem extra lines

1c0d84e

rem extra lines again

5531b87

comment out deprecation and save it for later

ff661b8

lex128 changed the title ~~Added functions for object properties~~ Added new functions get/setObjectProperty Sep 4, 2018

patrikjuvonen added enhancement New feature or request and removed new feature labels Sep 4, 2018

qaisjp added 2 commits September 5, 2018 03:02

Merge branch 'master' into feature/objectProperties

5e04140

Merge branch 'next' into feature/objectProperties

24b5009

qaisjp self-assigned this Sep 6, 2018

qaisjp changed the base branch from master to next September 6, 2018 09:06

qaisjp added 4 commits September 6, 2018 10:17

Fix formatting

3fa2635

Reset CResourceChecker.Data.h

97b8b0f

Merge getObjectProperties in getObjectProperty

41d4155

Fix oop

d970844

qaisjp merged this pull request into multitheftauto:next Sep 6, 2018

samr46 mentioned this pull request Sep 25, 2018

Restore get/setObjectMass functions #589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Added new functions get/setObjectProperty #162

Added new functions get/setObjectProperty #162

Uh oh!

lex128 commented Oct 8, 2017

Uh oh!

CrosRoad95 commented Oct 8, 2017

Uh oh!

Einheit-101 commented Oct 10, 2017

Uh oh!

lex128 commented Jan 1, 2018

Uh oh!

qaisjp commented Jan 1, 2018

Uh oh!

Citizen01 Jan 1, 2018

Uh oh!

lex128 Feb 20, 2018

Uh oh!

lex128 commented May 3, 2018 •

edited

Loading

Uh oh!

qaisjp commented May 3, 2018

Uh oh!

patrikjuvonen commented Sep 5, 2018 •

edited

Loading

Uh oh!

qaisjp commented Sep 6, 2018

Uh oh!

lex128 commented Sep 6, 2018

Uh oh!

Uh oh!

Uh oh!

Added new functions get/setObjectProperty #162

Added new functions get/setObjectProperty #162

Uh oh!

Conversation

lex128 commented Oct 8, 2017

Uh oh!

CrosRoad95 commented Oct 8, 2017

Uh oh!

Einheit-101 commented Oct 10, 2017

Uh oh!

lex128 commented Jan 1, 2018

Uh oh!

qaisjp commented Jan 1, 2018

Uh oh!

Citizen01 Jan 1, 2018

Choose a reason for hiding this comment

Uh oh!

lex128 Feb 20, 2018

Choose a reason for hiding this comment

Uh oh!

lex128 commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qaisjp commented May 3, 2018

Uh oh!

patrikjuvonen commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qaisjp commented Sep 6, 2018

Uh oh!

lex128 commented Sep 6, 2018

Uh oh!

Uh oh!

lex128 commented May 3, 2018 •

edited

Loading

patrikjuvonen commented Sep 5, 2018 •

edited

Loading