Skip to content

Add vehicle dff leak fix back #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 28, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2020

The model unload crash was fixed in PR #1623. I disabled 2 lines of code there:

m_pDFFManager->RestoreModel(usModelID);

and

CTxdStore_RemoveRef(pModelInfoInterface->usTextureDictionary);

The problem was CTxdStore_RemoveRef. I added this line because I thought MTA was not clearing texture references, but it turns out that someone added a fix for this problem somewhere in code, so this caused the problems with the texture references. This line of code is not needed there because there's already a fix somewhere in MTA, and we can remove it. This means we can restore the DFF leak fix, which is this line:

m_pDFFManager->RestoreModel(usModelID);

@StrixG StrixG added the bug Something isn't working label Aug 28, 2020
@StrixG StrixG added this to the 1.5.8 milestone Aug 28, 2020
@ghost ghost merged commit 969d497 into multitheftauto:master Aug 28, 2020
@ghost ghost deleted the restoreLeakFix branch October 16, 2020 09:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants