-
-
Notifications
You must be signed in to change notification settings - Fork 488
Allow allocating new object models using engineRequestModel #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If this is a separate bugfix, please can you submit it in a separate pull request? |
Excellent work, by the way :) |
I can't. Without this fix you can't create new objects and change models and textures. |
Thanks for the PR. I skimmed through the code, and it looks good. Testing the PR is going to take some time. I suggest we merge this after 1.5.8. |
Thanks you for help, @PlatinMTA !
|
Added test resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like good
ATOMIC = 1, | ||
TIME = 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh interesting, does gta skip over = 2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTA SA don't use model info with enum 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this is special type for parts of destroyed car
Co-authored-by: Qais Patankar <qaisjp@gmail.com>
…_objects_allocating
Fixed formatting |
@saml1er #1684 (comment) |
Co-authored-by: saml1er <10183157+saml1er@users.noreply.github.com>
|
Use first argument
object
inengineRequestModel
to allocate new model. New model will based on trashcan (1337).Changed valid objects list and this can cause bugs for old scripts. For example, you can't create object with ID 1. New method think that it's a ped.
Valid objects are here
API:
TEST: