-
-
Notifications
You must be signed in to change notification settings - Fork 490
xmlLoadFile
print error
#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xmlLoadFile
print error
#174
Conversation
Account Manager crash fix
Someone give that man a cookie! |
The idea behind this PR seems great. However, I'm a little concerned about backwards compatibility. For example, this code snippet would initialize a table with two fields instead of one, which can translate in unexpected behaviour of the script:
Although I think that most scripters only take into account the first return value currently, I wouldn't take that for granted. IMHO, a 100% backward-compatible solution would be definitely better. This PR faced a similar problem which was solved by modifying the behaviour of the function according to min_mta_version. Maybe this could be improved the same way? |
Better yet, instead of adding an extra field, just use LogWarning |
@Dezash , that sounds nice to me 👍 . engineLoadDFF does that too when trying to load a bad DFF, if I remember correctly. |
i change that print error in debugscript insted of return argument. |
xmlErrorTest.zip |
Thanks! |
xmlLoadFile print error in console when somethink wrong with xml
Now you dont know what's wrong with your file, now you know!
example script lua
wrong.xml