Enforce existing username length limit #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database code already limits usernames to 64 characters. See the CAccountManager::load function for more info about db upgrade.
botder
requested changes
Jan 10, 2021
This comment has been minimized.
This comment has been minimized.
botder
requested changes
Jan 10, 2021
This comment has been minimized.
This comment has been minimized.
botder
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment our database code already limits usernames to 64 characters long, but is not enforced elsewhere in the code, causing potential buffer overflows when handling usernames. To fix this let's limit the usernames to max length.
Note that whether the limit should be changed is out-of-scope for this PR. This PR only wants to get rid of potential issues caused by overlong usernames.
Should be backwards compatible as far as I can see.