Skip to content

Conversation

patrikjuvonen
Copy link
Contributor

@patrikjuvonen patrikjuvonen commented Jan 17, 2021

This lowers shadows and lights more towards ground level by default in MTA.

#1699 worked on this, but it edited a variable which is referenced by 20 different places unrelated to shadows and lights which we want to lower, hence it's safer to go through the addresses we want to edit, and apply the new float to them only.

I agree with @botder in that we don't really need to have a setting for this because it's a general improvement and not really something you want to toggle really.

A future PR could make this float editable in Lua maybe if it's useful for any scripters.

I tweaked the float a little bit and found 0.013f is a safe number and doesn't cause any flickering.

  • No flickering in 16 bit color mode and/or with near/far clip distance

This lowers shadows and lights more towards ground level.

Ground work (#1669) done by @TFP-dev

Lots of help and list of addresses by @botder - thank you very much
for teaching and explaining.

Co-authored-by: Marek Kulik <mk.botder@gmail.com>
Co-authored-by: TFP-dev <pi4096c@protonmail.com>
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Jan 17, 2021
@patrikjuvonen patrikjuvonen added this to the Confirmed Issues milestone Jan 17, 2021
@patrikjuvonen patrikjuvonen requested a review from botder January 17, 2021 21:55
@botder

This comment has been minimized.

@patrikjuvonen patrikjuvonen marked this pull request as draft January 18, 2021 20:21
@patrikjuvonen
Copy link
Contributor Author

You should add it to the multiplayer_sa project, because game_sa is meant to be a game interface library and multiplayer_sa is there for code modifications.

Thanks, moved the code under multiplayer_sa!

@patrikjuvonen patrikjuvonen marked this pull request as ready for review January 25, 2021 15:55
@patrikjuvonen patrikjuvonen merged commit e51c874 into multitheftauto:master Jan 28, 2021
@patrikjuvonen patrikjuvonen deleted the feature/improve-shadows branch January 28, 2021 10:33
@patrikjuvonen patrikjuvonen modified the milestones: Confirmed Issues, 1.6 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants