0009742: add support for Vec2s on createColPolygon client-side and allow passing in more Vec2s server-side #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a nice PR-merge streak in this project recently so I really do hope this PR won't get stuck like the one I created 😄 |
|
Good job! There's not much code to review, if it works properly, I'll be happy to merge. |
qaisjp
approved these changes
Jul 5, 2018
|
Thank you both @4O4 and @patrikjuvonen. Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mantis Bug Tracker issue:
9742
Co-contributors:
@4O4 (PR)
I was fixing someone's Lua script and that's how I encountered this bug. I searched for the issue on Mantis Bug Tracker and then I found a link to @4O4's old PR which I reviewed. My patch is slightly different. I read the comments @qaisjp had written. I did not directly copy any code from his PR, but I do want to give him credits obviously for delivering a patch before me.
Function:
createColPolygon
Summary:
Testing:
While I could provide my own tests, I found that @4O4's tests do the same thing. All tests passed and making complicated polygon colshapes is working.