Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0008523: Fix empty string in getVehicleNameFromModel (instead of false) #219

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
4 participants
@emre1702
Copy link
Contributor

emre1702 commented Jul 4, 2018

Bugtracker:
https://bugs.mtasa.com/view.php?id=8523

Currently getVehicleNameFromModel returns an empty string when the model is invalid.
Instead it should return "false".

Is a confirmed bug in bugtracker ...
And the change is really small and was really fast - so you can reject the PR if you want.

@Pirulax

This comment has been minimized.

Copy link
Contributor

Pirulax commented Jul 4, 2018

And the change is really small and was really fast - so you can reject the PR if you want.

Alright. xD

@qaisjp qaisjp merged commit 24fb0cc into multitheftauto:master Jul 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@qaisjp

This comment has been minimized.

Copy link
Member

qaisjp commented Jul 4, 2018

Thank you! Nice catch.

@patrikjuvonen patrikjuvonen added the bug label Aug 7, 2018

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 7, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018

@patrikjuvonen patrikjuvonen moved this from In progress to Done in release/v1.5.6 Aug 7, 2018

@patrikjuvonen patrikjuvonen changed the title #8523 - Fix empty string in getVehicleNameFromModel (instead of false) 0008523: Fix empty string in getVehicleNameFromModel (instead of false) Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.