Skip to content

Add engineStreamingGetUsedMemory #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Pirulax
Copy link
Contributor

@Pirulax Pirulax commented Jun 19, 2021

Function for retrieving the amount of memory (in bytes) used by the GTA streamer.

@Pirulax
Copy link
Contributor Author

Pirulax commented Jun 19, 2021

Maybe engineStreamingGetMemoryInUse is a more fitting? Or engineStreamingGetMemoryUsed?

@StrixG StrixG added the enhancement New feature or request label Jun 19, 2021
@AlexTMjugador
Copy link
Member

AlexTMjugador commented Jun 23, 2021

I'd suggest engineGetStreamingMemoryUsed, because most engine functions follow the naming convention of engine + verb + object, so it's arguably more consistent. But your choice is as good as mine 😄

@Pirulax
Copy link
Contributor Author

Pirulax commented Jun 23, 2021

It is more consistent, but I want to add more streaming functions in the feature, so I thought that placing streaming after engine might make those functions more consistent.

Co-authored-by: Marek Kulik <me@botder.com>
@botder botder merged commit b170d02 into multitheftauto:master Aug 3, 2021
@StrixG StrixG added this to the Next Release (1.5.9) milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants