0009522: reset jetpack and choking states upon animation - and the other way around

[patrikjuvonen]

Mantis Bug Tracker issue

9522

Summary

• Fixes many bugs related to animations, jetpack and choking;
• Pretty small and simple fix, easy to test.

Tests

Note, that tests 1 and 2 on either category will not function as expected for Ped elements (in either case, choking/jetpack will stay on). You should use yourself or another Player element for testing. Cause for this behavior is this if statement. Changing it now would make it backwards incompatible. In my opinion this should have been unified for both elements in the first place.

Jetpack

---

Test 1

1. Give ped a jetpack.
2. Set their position to something with warp enabled.
3. Expectation: jetpack should be removed.

---

Test 2

1. Give ped a jetpack.
2. Set their position to something with warp disabled.
3. Expectation: jetpack should not be removed.

---

Test 3

1. Give ped a jetpack.
2. Freeze them.
3. Expectation: jetpack should not be removed.

---

Test 4

1. Give ped a jetpack.
2. Set their animation.
3. Expectation: jetpack should be removed.

---

Test 5

1. Give ped a jetpack.
2. Set their animation.
3. Give them a jetpack.
4. Expectation: they should now be on a jetpack.

---

Test 6

1. Give ped a jetpack.
2. Set their animation.
3. Give them a jetpack.
4. Remove their jetpack.
5. Set their model to something else.
6. Expectation: they should not be doing the animation you set them in step 2.

---

Test 7

1. Give ped a jetpack.
2. Set them choking.
3. Expectation: jetpack should be removed.

---

Test 8

1. Give ped a jetpack.
2. Set them choking.
3. Give them a jetpack.
4. Expectation: they should now be on a jetpack.

---

Choking

---

Test 1

1. Choke a ped.
2. Set their position to something with warp enabled.
3. Expectation: they should no longer be choking.

---

Test 2

1. Choke a ped.
2. Set their position to something with warp disabled.
3. Expectation: they should be choking.

---

Test 3

1. Choke a ped.
2. Freeze them.
3. Expectation: they should be choking.

---

Test 4

1. Choke a ped.
2. Set their animation.
3. Expectation: they should no longer be choking.

---

Test 5

1. Choke a ped.
2. Set their animation.
3. Set them choking.
4. Expectation: they should be choking.

---

Test 6

1. Choke a ped.
2. Set their animation.
3. Set them choking.
4. Remove their jetpack.
5. Set their model to something else.
6. Expectation: they should not be doing the animation you set them in step 2.

[ghost]

We need to observe the latest fix for animations, if there are no more crashes, this PR can be merged. For now it's better to wait for a couple of days.

[qaisjp]

@saml1er is this safe to merge now? how are animation crashes?