Raw data loading option for engineLoadIFP #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New syntax: engineLoadIFP ( string ifp_file / string raw_data, string CustomBlockName ) Added option to use raw data instead of a file name.
qaisjp
approved these changes
Jul 21, 2018
ghost
reviewed
Jul 21, 2018
| bool CFileReader::LoadDataBufferToMemory(const SString& buffer) | ||
| { | ||
| std::streamsize m_BufferSize = buffer.size(); | ||
| if (m_BufferSize == eIFSTREAM::SIZE_ERROR) |
There was a problem hiding this comment.
can you please rename m_BufferSize to iBufferSize for consistency? I made the same mistake within CFileReader::LoadFileToMemory, so please do me one more favor and rename m_iFileSize to iFileSize.
There was a problem hiding this comment.
Sure. Done in 0cf25a0.
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified function: engineLoadIFP
New syntax: engineLoadIFP ( string ifp_file / string raw_data, string CustomBlockName )
Added option to use raw data instead of a file name.