Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw data loading option for engineLoadIFP #247

Merged
merged 3 commits into from Jul 22, 2018

Conversation

Projects
4 participants
@samr46
Copy link
Contributor

samr46 commented Jul 21, 2018

Modified function: engineLoadIFP

New syntax: engineLoadIFP ( string ifp_file / string raw_data, string CustomBlockName )

Added option to use raw data instead of a file name.

samr46 and others added some commits Jul 21, 2018

samr46
Modified function: engineLoadIFP
New syntax: engineLoadIFP ( string ifp_file / string raw_data, string CustomBlockName )

Added option to use raw data instead of a file name.

@qaisjp qaisjp requested a review from saml1er Jul 21, 2018

@qaisjp

qaisjp approved these changes Jul 21, 2018

bool CFileReader::LoadDataBufferToMemory(const SString& buffer)
{
std::streamsize m_BufferSize = buffer.size();
if (m_BufferSize == eIFSTREAM::SIZE_ERROR)

This comment has been minimized.

@saml1er

saml1er Jul 21, 2018

Member

can you please rename m_BufferSize to iBufferSize for consistency? I made the same mistake within CFileReader::LoadFileToMemory, so please do me one more favor and rename m_iFileSize to iFileSize.

This comment has been minimized.

@samr46

samr46 Jul 21, 2018

Author Contributor

Sure. Done in 0cf25a0.

@saml1er saml1er merged commit 3b68f4c into multitheftauto:master Jul 22, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 7, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018

@patrikjuvonen patrikjuvonen moved this from In progress to Done in release/v1.5.6 Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.