Skip to content

#251: merge the two fire extinguish functions into one extinguishFire #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2018
Merged

#251: merge the two fire extinguish functions into one extinguishFire #252

merged 1 commit into from
Jul 23, 2018

Conversation

patrikjuvonen
Copy link
Contributor

GitHub issue:
#251

Summary:

  • Replaced redundant extinguishAllFires and extinguishFireInRadius with extinguishFire;
  • Does not require deprecation warnings as these functions are new to 1.5.6 anyway;
  • Pretty small and simple fix, easy to test.

@qaisjp qaisjp added this to the 1.5.6 milestone Jul 23, 2018
@qaisjp qaisjp merged commit eeff04b into multitheftauto:master Jul 23, 2018
qaisjp added a commit that referenced this pull request Jul 23, 2018
@qaisjp
Combine extinguishFire (pr #252, fix #251)
3924406
@patrikjuvonen patrikjuvonen deleted the github-issue-251 branch July 23, 2018 00:25
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@qaisjp qaisjp

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@patrikjuvonen @qaisjp