New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#251: merge the two fire extinguish functions into one extinguishFire #252

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
2 participants
@patrikjuvonen
Collaborator

patrikjuvonen commented Jul 22, 2018

GitHub issue:
#251

Summary:

  • Replaced redundant extinguishAllFires and extinguishFireInRadius with extinguishFire;
  • Does not require deprecation warnings as these functions are new to 1.5.6 anyway;
  • Pretty small and simple fix, easy to test.

@qaisjp qaisjp added this to the 1.5.6 milestone Jul 23, 2018

@qaisjp qaisjp merged commit eeff04b into multitheftauto:master Jul 23, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@qaisjp qaisjp added this to Done in release/v1.5.6 via automation Jul 23, 2018

qaisjp added a commit that referenced this pull request Jul 23, 2018

@patrikjuvonen patrikjuvonen deleted the patrikjuvonen:github-issue-251 branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment