Skip to content

Improve debug info for garbage collected files #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 10, 2018
Merged

Improve debug info for garbage collected files #312

merged 3 commits into from
Aug 10, 2018

Conversation

Dezash
Copy link
Contributor

@Dezash Dezash commented Aug 7, 2018 •
edited by patrikjuvonen
Loading

Changed warnings for garbage collected files to display the line in which the file was opened via fileOpen or fileCreate instead of displaying useless information about Lua garbage collector.

This PR closes #309

@Dezash Dezash mentioned this pull request Aug 7, 2018
Closed
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Aug 7, 2018
@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018
@patrikjuvonen patrikjuvonen requested review from qaisjp and ccw808 August 7, 2018 13:58
@qaisjp qaisjp self-assigned this Aug 7, 2018
qaisjp
qaisjp approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested if this works, but the code LGTM. 👍

@qaisjp
Copy link
Contributor

qaisjp commented Aug 10, 2018

By the way, your git author is unknown <drakath13@gmail.com>. You should run git config --global user.name "Gabrielius Lastname" (feel free to omit your surname).

qaisjp
qaisjp approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Tested and code LGTM. :shipit:

@qaisjp qaisjp merged commit 50082a0 into multitheftauto:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccw808 ccw808 Awaiting requested review from ccw808

1 more reviewer

@qaisjp qaisjp qaisjp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@qaisjp qaisjp

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.6
Development

Successfully merging this pull request may close these issues.

Hide line numbers when files are garbage collected
3 participants
@Dezash @qaisjp @patrikjuvonen