New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug info for garbage collected files #312

Merged
merged 3 commits into from Aug 10, 2018

Conversation

Projects
3 participants
@Dezash
Contributor

Dezash commented Aug 7, 2018

Changed warnings for garbage collected files to display the line in which the file was opened via fileOpen or fileCreate instead of displaying useless information about Lua garbage collector.

This PR closes #309

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 7, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018

@patrikjuvonen patrikjuvonen requested review from qaisjp and ccw808 Aug 7, 2018

@qaisjp qaisjp self-assigned this Aug 7, 2018

@qaisjp

qaisjp approved these changes Aug 7, 2018 edited

Haven't tested if this works, but the code LGTM. 👍

release/v1.5.6 automation moved this from In progress to Ready Aug 7, 2018

@qaisjp

This comment has been minimized.

Show comment
Hide comment
@qaisjp

qaisjp Aug 10, 2018

Member

By the way, your git author is unknown <drakath13@gmail.com>. You should run git config --global user.name "Gabrielius Lastname" (feel free to omit your surname).

Member

qaisjp commented Aug 10, 2018

By the way, your git author is unknown <drakath13@gmail.com>. You should run git config --global user.name "Gabrielius Lastname" (feel free to omit your surname).

@qaisjp

qaisjp approved these changes Aug 10, 2018

Thank you!

Tested and code LGTM. :shipit:

@qaisjp qaisjp merged commit 50082a0 into multitheftauto:master Aug 10, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

release/v1.5.6 automation moved this from Ready to Done Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment