Add main menu setting for browser GPU rendering #3816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds options to "web browser" tab in main menu settings
TracerDS
suggested changes
Oct 19, 2024
TracerDS
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two options to "web browser" tab in the main menu settings:
browser_enable_gpu=1)browser_enable_gpu_compositing=1)GPU rendering must be enabled for GPU compositing to be available. Both options require a restart upon change to take effect.
Adds a clientside Lua function to check if browser GPU is enabled:
Note: for some reason the GPU is not being disabled for me, even though I've debugged and can see the
disable-gpuflag being applied (http://gta.rockstarvision.com/vehicleviewer still works for example, which relies on WebGL). Need others to test and see if they get the same results, as it doesn't make much sense 🤔GPU has always been disabled in MTA, until #2933 (merged 2 weeks ago)
Update: according to @theSarrum these changes work (both enabling and disabling), tested by attempting to load a page with WebGL content.