Skip to content

Fix sourceResourceRoot for client-sided events #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

Nico8340
Copy link
Member

@Nico8340 Nico8340 commented Feb 13, 2025

Fixes #2965

@TheNormalnij TheNormalnij added the backwards-incompatible Should be merged after the release of 1.7.1 label Feb 13, 2025
@Dutchman101
Copy link
Member

Can you clarify the way this is backwards incompatible?

@Nico8340
Copy link
Member Author

Can you clarify the way this is backwards incompatible?

@TheNormalnij?

@TheNormalnij
Copy link
Member

Can you clarify the way this is backwards incompatible?

I think some developers know current behavior and have some workarounds for it. getElementParent returns a different element for sourceResourceRoot after these changes.
I suggest merging it with 1.6.1 release to not repeat a story with SVG,

@Dutchman101
Copy link
Member

Can you clarify the way this is backwards incompatible?

I think some developers know current behavior and have some workarounds for it. getElementParent returns a different element for sourceResourceRoot after these changes. I suggest merging it with 1.6.1 release to not repeat a story with SVG,

I don't think it will make a big difference, because auto updates will bring people to 1.6.1 once it's released, and these clients remain compatible with any 1.6.x release. Server owners barely keep track of what to fix up after updates. For the few servers that may have a workaround, briefly biting the sour apple is the best way. I don't expect a significant impact anyways.

@Dutchman101 Dutchman101 merged commit 2f4a0a4 into multitheftauto:master Mar 1, 2025
6 checks passed
MTABot pushed a commit that referenced this pull request Mar 1, 2025
2f4a0a4 Fix `sourceResourceRoot` for client-sided events (#4021)
@botder
Copy link
Member

botder commented Mar 1, 2025

Why are we merging backwards incompatible PRs now?

@botder botder added this to the 1.6.1 milestone Mar 2, 2025
Dutchman101 added a commit that referenced this pull request Mar 2, 2025
… to feedback about backwards compatibility.

This reverts commit 2f4a0a4.
MTABot pushed a commit that referenced this pull request Mar 2, 2025
b99cb95 Revert "Fix `sourceResourceRoot` for client-sided events (#4021)" due to feedback about backwards compatibility.
@Dutchman101
Copy link
Member

Dutchman101 commented Mar 2, 2025

Alright, reverted in b99cb95. No build with the reverted change was distributed.

@Nico8340 if you could please open a new PR for the future?

@Nico8340 Nico8340 deleted the sourceresourceroot branch July 31, 2025 21:19
@multitheftauto multitheftauto deleted a comment from TheNormalnij Aug 17, 2025
@Dutchman101
Copy link
Member

Reintroduced the change in 899c84c for MTA 1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Should be merged after the release of 1.7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourceResourceRoot is incorrect in event handlers
4 participants