Skip to content

Add onElementPositionChange event to SetElementPosition for anti-cheat compatibility #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add onElementPositionChange event to SetElementPosition for anti-cheat compatibility #4392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc689ae
Add onElementPositionChange event to SetElementPosition for anti-chea…
frqher Aug 25, 2025
9f2aebb
Add old position parameters to onElementPositionChange event
frqher Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Server/mods/deathmatch/logic/CGame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,6 +1672,7 @@ void CGame::AddBuiltInEvents()
m_Events.AddEvent("onElementInteriorChange", "oldInterior, newInterior", nullptr, false);
m_Events.AddEvent("onElementAttach", "attachSource, attachOffsetX, attachOffsetY, attachOffsetZ, attachOffsetRX, attachOffsetRY, attachOffsetRZ", nullptr, false);
m_Events.AddEvent("onElementDetach", "detachSource, detachWorldX, detachWorldY, detachWorldZ, detachWorldRX, detachWorldRY, detachWorldRZ", nullptr, false);
m_Events.AddEvent("onElementPositionChange", "oldX, oldY, oldZ, newX, newY, newZ", nullptr, false);

// Radar area events

Expand Down
24 changes: 24 additions & 0 deletions Server/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,9 @@ bool CStaticFunctionDefinitions::SetElementPosition(CElement* pElement, const CV
player->SetTeleported(true);
}

// Get element old position
CVector elementOldPosition = pElement->GetPosition();

// Update our position for that entity.
pElement->SetPosition(vecPosition);

Expand Down Expand Up @@ -1340,6 +1343,27 @@ bool CStaticFunctionDefinitions::SetElementPosition(CElement* pElement, const CV
if (ped && ped->HasJetPack())
m_pPlayerManager->BroadcastOnlyJoined(CElementRPCPacket(ped, GIVE_PED_JETPACK, *BitStream.pBitStream));

// This event is triggered server-side to allow anti-cheat scripts to distinguish between
// position changes made by the server (e.g., elevators, scripted teleports) and those made by the client.
// Without this event, anti-cheat systems may falsely detect legitimate server-side teleports as cheats,
// since they only check the distance between old and new positions.
// By listening to this event, anti-cheat scripts can safely ignore server-initiated position changes.
CLuaArguments Arguments;
Arguments.PushElement(pElement);
Arguments.PushNumber(elementOldPosition.fX);
Arguments.PushNumber(elementOldPosition.fY);
Arguments.PushNumber(elementOldPosition.fZ);
Arguments.PushNumber(vecPosition.fX);
Arguments.PushNumber(vecPosition.fY);
Arguments.PushNumber(vecPosition.fZ);
Arguments.PushBool(bWarp);


if (!pElement->CallEvent("onElementPositionChange", Arguments))
{
return false;
}

return true;
}

Expand Down