Skip to content

Add setPedFightingStyle for clientside peds #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 2, 2019
Merged

Add setPedFightingStyle for clientside peds #810

merged 6 commits into from
Sep 2, 2019

Conversation

StrixG
Copy link
Contributor

@StrixG StrixG commented Feb 11, 2019

No description provided.

@qaisjp qaisjp added the enhancement New feature or request label Feb 12, 2019
@StrixG StrixG closed this Feb 13, 2019
@StrixG StrixG reopened this Feb 13, 2019
qaisjp
qaisjp previously requested changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert edc9180

It should return false on failure. Only getters return nil on failure.

@botder
Copy link
Member

botder commented Feb 17, 2019

Wait for the result of #821 before reverting, if required.

@patrikjuvonen patrikjuvonen added this to the Backlog milestone Feb 22, 2019
patrikjuvonen
patrikjuvonen suggested changes Aug 17, 2019
View reviewed changes
@patrikjuvonen patrikjuvonen dismissed qaisjp’s stale review August 17, 2019 16:32

Up-to-date review submitted.

@patrikjuvonen patrikjuvonen self-assigned this Aug 17, 2019
patrikjuvonen
patrikjuvonen approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@patrikjuvonen patrikjuvonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All ready to go once 1.5.7 is released.

@patrikjuvonen patrikjuvonen modified the milestones: Backlog, 1.6 Aug 19, 2019
@patrikjuvonen patrikjuvonen reopened this Sep 2, 2019
@patrikjuvonen patrikjuvonen merged commit d21c66f into multitheftauto:master Sep 2, 2019
@StrixG StrixG deleted the setPedFightingStyle-clientside branch September 7, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrikjuvonen patrikjuvonen patrikjuvonen approved these changes

@qaisjp qaisjp qaisjp left review comments

Assignees

@patrikjuvonen patrikjuvonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.
4 participants
@StrixG @botder @qaisjp @patrikjuvonen