Skip to content

Add missing high_detail_peds setting that was supposed to be added in #231 #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 28, 2019
Merged

Add missing high_detail_peds setting that was supposed to be added in #231 #832

merged 12 commits into from
May 28, 2019

Conversation

patrikjuvonen
Copy link
Contributor

This PR adds the missing high_detail_peds setting that was supposed to be added in #231.

Whether we actually want to keep #231 in as a feature (competitive advantage), should be discussed in #708. I think we could introduce a server-side option to control this feature.

@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Feb 21, 2019
@patrikjuvonen patrikjuvonen added this to the Backlog milestone Feb 21, 2019
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Further potential improvements:

  • Setting could have instant effect if it is currently "reset"
  • Setting could take effect at next "reset" instead of just next connect

@patrikjuvonen patrikjuvonen changed the title Add missing high_detail_peds setting that was supposed to be added in #231 WIP: Add missing high_detail_peds setting that was supposed to be added in #231 May 9, 2019
@patrikjuvonen patrikjuvonen changed the title WIP: Add missing high_detail_peds setting that was supposed to be added in #231 Add missing high_detail_peds setting that was supposed to be added in #231 May 19, 2019
@patrikjuvonen patrikjuvonen requested a review from qaisjp May 19, 2019 20:22
@patrikjuvonen patrikjuvonen modified the milestones: Backlog, 1.5.7 May 26, 2019
@patrikjuvonen patrikjuvonen merged commit 67447ca into multitheftauto:master May 28, 2019
@patrikjuvonen patrikjuvonen deleted the feature/add-high-detail-peds-setting branch May 28, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants