-
-
Notifications
You must be signed in to change notification settings - Fork 480
Add missing high_detail_peds setting that was supposed to be added in #231 #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patrikjuvonen
merged 12 commits into
multitheftauto:master
from
patrikjuvonen:feature/add-high-detail-peds-setting
May 28, 2019
Merged
Add missing high_detail_peds setting that was supposed to be added in #231 #832
patrikjuvonen
merged 12 commits into
multitheftauto:master
from
patrikjuvonen:feature/add-high-detail-peds-setting
May 28, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Further potential improvements:
- Setting could have instant effect if it is currently "reset"
- Setting could take effect at next "reset" instead of just next connect
qaisjp
reviewed
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
high_detail_peds
setting that was supposed to be added in #231.Whether we actually want to keep #231 in as a feature (competitive advantage), should be discussed in #708. I think we could introduce a server-side option to control this feature.