Skip to content

Conversation

TheNormalnij
Copy link
Member

Fix issue #711

Event onClientFileDownloadComplete has parameter requestResource: resource that called downloadFile. The source of this event is the root element of the resource that download file.

@qaisjp qaisjp requested a review from ccw808 May 17, 2019 23:04
@qaisjp
Copy link
Contributor

qaisjp commented May 17, 2019

@ccw808 — if I recall correctly, you once mentioned that you were unhappy with downloadFile. Do you think we should add new features to downloadFile in favour of encouraging other methods of sending files?

@TheNormalnij
Copy link
Member Author

TheNormalnij commented May 17, 2019

Resources for testing.

Note from admin: please try to upload files directly. Thanks! resources.zip

@TheNormalnij
Copy link
Member Author

I need a more flexible and convenient tool for downloading files. Now I have to use exports for this, but I don't see that this is a good way. Using downloadFile directly is more convenient.

@patrikjuvonen patrikjuvonen added the enhancement New feature or request label May 18, 2019
@onikyannn
Copy link
Contributor

Any updates?

@ghost
Copy link

ghost commented Feb 4, 2020

Why dont you use fetchRemote ? I recently implemented abortRemoteRequest and getRemoteRequestInfo which both can handle downloads pretty well.

@TheNormalnij
Copy link
Member Author

fetchRemote don't math CRC hash. Also, downloadFile use specific HTTP server from mtaserver.conf and don't use ACL right (function is safe).

@ccw808
Copy link
Member

ccw808 commented Mar 23, 2020

Looks good to me

@qaisjp qaisjp added this to the 1.6 milestone Mar 24, 2020
@qaisjp qaisjp added the feedback Further information is requested label Mar 24, 2020
@qaisjp qaisjp merged commit 302f512 into multitheftauto:master Mar 30, 2020
@qaisjp qaisjp removed the feedback Further information is requested label Mar 30, 2020
@StrixG StrixG linked an issue May 16, 2020 that may be closed by this pull request
@TheNormalnij TheNormalnij deleted the downloadFile-update branch October 27, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using downloadFile to download a file of another resource
5 participants