Skip to content

Fix #798: Pin down startResource and stopResource behaviour #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2019
Merged

Fix #798: Pin down startResource and stopResource behaviour #957

merged 1 commit into from
May 26, 2019

Conversation

StrixG
Copy link
Contributor

@StrixG StrixG commented May 24, 2019 •
edited
Loading

startResource and stopResource functions now return false if already in the target state.
Closes #798

qaisjp
qaisjp approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qaisjp qaisjp requested a review from botder May 24, 2019 00:48
@patrikjuvonen patrikjuvonen added the bug Something isn't working label May 24, 2019
@qaisjp qaisjp merged commit a4a9fa0 into multitheftauto:master May 26, 2019
@qaisjp qaisjp added this to the 1.5.7 milestone May 26, 2019
@StrixG StrixG deleted the 798-startresource branch May 26, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botder botder botder approved these changes

+1 more reviewer

@qaisjp qaisjp qaisjp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.5.7
Development

Successfully merging this pull request may close these issues.

Pin down startResource and stopResource behaviour
4 participants
@StrixG @qaisjp @botder @patrikjuvonen