-
-
Notifications
You must be signed in to change notification settings - Fork 171
admin2: Fix #152 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin2: Fix #152 #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering refactoring this stuff instead of copying the code
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation needs some small fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is better, but you forgot line 574. Still has 3 spaces.
Co-Authored-By: Qais Patankar <qaisjp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think more info is being synced than necessary now, but this is much better now, thank you very much!
Fixes #152
Now if we use DOWN or UP arrow key, informations like freeze,mute,ip,serial etc will be update/set