admin2: Finally fix for #104 #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! @qaisjp merged it in. I fixed some formatting consistency issues and some old typo in blend weather error message. Also as a general comment: it's better to not keep old code commented in code when it's being replaced by something else. I assume you wanted to keep the door open in case we wanted to keep the old buttons on the sides so it will be easier to change back, but this introduces an unwanted blocker, which needs to be resolved before the PR can be merged (PRs should generally be as complete as possible). |
|
Sorry, I didn't see you push 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
Use combobox instead of editbox for change weather. This PR also fix blend weather error.