Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT(client, server): Add more control over UDP stream. #5931

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

irakr
Copy link
Contributor

@irakr irakr commented Oct 16, 2022

As requested in #5517 this commit implements the ability to control the inbound and outbound UDP audio stream by providing additional options in the network settings. The client and the server works together to provide these individual controls.

An additional section called "UDP stream mode" has been added. Each of the options can be selected to specify the behaviour of the UDP as well as TCP stream.

Also a protobuf message component called "disable_udp_mode" is added under UserState message which is used to force the server to use TCP mode only.

Implements #5517

Co-Authored-By: Krzmbrzl krzmbrzl@gmail.com

Checks

irakr and others added 2 commits October 19, 2022 02:07
As requested in mumble-voip#5517 this commit implements the ability to control
the inbound and outbound UDP audio stream by providing additional
options in the network settings. The client and the server works
together to provide these individual controls.

An additional section called "UDP stream mode" has been added.
Each of the options can be selected to specify the behaviour of the UDP
as well as TCP stream.

Also a protobuf message component called "disable_udp_mode" is
added under UserState message which is used to force the server to
use TCP mode only.

Implements mumble-voip#5517

Co-Authored-By: Krzmbrzl <krzmbrzl@gmail.com>
@irakr
Copy link
Contributor Author

irakr commented Oct 19, 2022

@Krzmbrzl Are the changes under src/tests/TestSettingsJSONSerialization/ good?

@Krzmbrzl
Copy link
Member

I will have a look at this eventually but atm I have too many things piling up on my todo-list and too little time to work on everything. I'll come back to reviewing this once I have chopped away some of the other stuff...

@irakr
Copy link
Contributor Author

irakr commented Nov 17, 2022

No worries. Take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants